homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

go 1.23rc1

Open stefanb opened this issue 1 year ago • 3 comments

Announcements:

  • rc1: https://groups.google.com/g/golang-announce/c/8ciOP5ve_CM
  • newer... https://groups.google.com/g/golang-announce/search?q=Go%201.23%20release

According to release schedule the final 1.23.0 is expected to be released in August 2024.

Draft release notes: https://tip.golang.org/doc/go1.23

Go 1.23 milestone: GitHub milestone details

Go 1.23 release dashboard: https://dev.golang.org/release

Downloads: https://go.dev/dl/

Previous major release: https://github.com/Homebrew/homebrew-core/pull/157782


  • [X] Have you followed the guidelines for contributing?
  • [X] Have you ensured that your commits follow the commit style guide?
  • [X] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

stefanb avatar Jun 21 '24 17:06 stefanb

@stefanb Let me know when you want the no-fail-fast label here.

p-linnane avatar Jun 21 '24 17:06 p-linnane

@p-linnane, please add the no-fail-fast label, or whatever is needed to not abort the builds after the first failure. Perhaps also long build (or something similar) label will be needed. Thanks!

stefanb avatar Jun 21 '24 18:06 stefanb

need to have long build jobs for deps (cancelled and re-ran)

chenrui333 avatar Jun 21 '24 20:06 chenrui333

Not sure what to do with frugal, which failed to build with error:

  ==> Downloading https://github.com/Workiva/frugal/archive/refs/tags/v3.17.13.tar.gz
  curl: (22) The requested URL returned error: 404

The original repository https://github.com/Workiva/frugal is gone, but it wasn't simply renamed, in case of which github would take care of redirects, but it seems that a new repository https://github.com/Workiva/frugal-public was created with NO tags, so we cant just point the formula there and the new repository doesn't accepts issues, so we can't ask them there about such weird renaming process.

stefanb avatar Jul 01 '24 18:07 stefanb

I'd disable frugal with :repo_removed

SMillerDev avatar Jul 02 '24 07:07 SMillerDev

https://twitter.com/golang/status/1823404920583663807

Go 1.23.0 released 🎉

blacktop avatar Aug 13 '24 17:08 blacktop

Just wanna give a big shoutout to you @stefanb for all your hard work on this! 🤘 Thank you!

bstncartwright avatar Aug 13 '24 18:08 bstncartwright

Worth noting that Go is now able to download and upgrade the target toolchains itself. Maybe this could be used to lesson the load on providing brewed versions.

andig avatar Aug 14 '24 13:08 andig

what are causing the failures here in the CI? Something that needs to be addressed in this PR?

TristanSpeakEasy avatar Aug 15 '24 13:08 TristanSpeakEasy

@TristanSpeakEasy so far it seems that most of the failures can be tackled in follow-up PRs after this is merged.

Some formulae are not yet compatible with Go 1.23 and will need to be pinned to 1.22 until they are compatible.

Some formulae have hash mismatches or have some other problems that should be investigated.

stefanb avatar Aug 15 '24 13:08 stefanb

Hi all. Just catching up on this PR and related comments. What is the expected time frame for this PR to be merged? I am ready to help with any remaining testing, documentation, code, or related tasks. Sincerely appreciate the insight.

mprimeaux avatar Aug 15 '24 22:08 mprimeaux

Relevant discussion: https://github.com/orgs/Homebrew/discussions/2618

stefanb avatar Aug 16 '24 07:08 stefanb

Follow-ups needed based on the latest build logs:

Incompatible with Go 1.23 due to https://github.com/golang/go/issues/67401 (pin to Go 1.22 or add -ldflags=-checklinkname=0 unless upstreams have releases compatible version in the mean time):

  • [x] aliyunpan: https://github.com/Homebrew/homebrew-core/pull/178769, https://github.com/tickstep/aliyunpan/issues/437, https://github.com/Homebrew/homebrew-core/pull/181082
  • [x] baidupcs-go: https://github.com/Homebrew/homebrew-core/pull/181441, https://github.com/qjfoidnh/BaiduPCS-Go/issues/336
  • [x] bigquery-emulator: https://github.com/Homebrew/homebrew-core/pull/181557, https://github.com/goccy/bigquery-emulator/issues/348
  • [x] cloudpan189-go: https://github.com/Homebrew/homebrew-core/pull/181438, https://github.com/tickstep/cloudpan189-go/issues/101
  • [x] grafana: https://github.com/Homebrew/homebrew-core/pull/181440, https://github.com/grafana/grafana/issues/89796
  • [x] grafana-agent: https://github.com/Homebrew/homebrew-core/pull/181439, https://github.com/grafana/agent/issues/6972
  • [x] hof: https://github.com/Homebrew/homebrew-core/pull/181511, https://github.com/hofstadter-io/hof/issues/391
  • [ ] influxdb@1
  • [x] juicefs: https://github.com/Homebrew/homebrew-core/pull/181442, https://github.com/juicedata/juicefs/issues/5047
  • [x] kuttl: https://github.com/Homebrew/homebrew-core/pull/181513, https://github.com/kudobuilder/kuttl/issues/546
  • [ ] logcli
  • [ ] loki
  • [x] mimirtool, https://github.com/Homebrew/homebrew-core/pull/181594, https://github.com/grafana/mimir/issues/9033
  • [x] neosync, regression build works fine, https://github.com/Homebrew/homebrew-core/actions/runs/10435665414
  • [x] nexttrace: https://github.com/Homebrew/homebrew-core/pull/181811, https://github.com/nxtrace/NTrace-core/issues/247
  • [x] pcp, https://github.com/Homebrew/homebrew-core/pull/181541, https://github.com/dennis-tra/pcp/issues/30
  • [ ] promtail
  • [x] pulumi, https://github.com/Homebrew/homebrew-core/pull/181538, https://github.com/pulumi/pulumi/issues/17003
  • [x] rdb, https://github.com/Homebrew/homebrew-core/pull/181537, https://github.com/HDT3213/rdb/issues/37
  • [x] serf, https://github.com/Homebrew/homebrew-core/pull/181539, https://github.com/hashicorp/serf/issues/736
  • [x] teleport https://github.com/Homebrew/homebrew-core/pull/182825, https://github.com/gravitational/teleport/pull/45593
  • [x] vitess: https://github.com/Homebrew/homebrew-core/pull/182757, https://github.com/vitessio/vitess/issues/16015
  • [x] zoro: https://github.com/Homebrew/homebrew-core/pull/182755, https://github.com/txthinking/zoro/issues/29

Checksum changed:

  • [x] https://github.com/Homebrew/homebrew-core/pull/181402, https://github.com/hickford/git-credential-oauth/issues/61
  • [x] meek: https://github.com/Homebrew/homebrew-core/pull/181802
  • [ ] wireguard-go
  • [x] zrok: https://github.com/Homebrew/homebrew-core/pull/181779

Other:

  • [ ] cortex
  • [x] dissent, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10435677049
  • [ ] func-e, upstream issue, https://github.com/tetratelabs/func-e/issues/448
  • [x] garble: https://github.com/burrowers/garble/issues/859
  • [x] govulncheck, https://github.com/Homebrew/homebrew-core/pull/181468
  • [x] imgproxy, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10441710839
  • [ ] kapacitor
  • [x] llgo, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10441713037
  • [x] logdy, https://github.com/Homebrew/homebrew-core/pull/181593
  • [x] navidrome, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10441714604
  • [ ] operator-sdk, https://github.com/operator-framework/operator-sdk/issues/6788
  • [x] podsync, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10441715466
  • [x] staticcheck, https://github.com/Homebrew/homebrew-core/pull/181466
  • [x] twty: https://github.com/Homebrew/homebrew-core/pull/181592
  • [x] vhs, regression builds fine, https://github.com/Homebrew/homebrew-core/actions/runs/10441720682

stefanb avatar Aug 16 '24 22:08 stefanb