homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

systemd 256

Open BrewTestBot opened this issue 1 year ago • 2 comments

Created by brew bump


Created with brew bump-formula-pr.

  • [ ] resource blocks have been checked for updates.
release notes

BrewTestBot avatar Jun 12 '24 00:06 BrewTestBot

Error: Permission denied @ rb_sysopen - /home/linuxbrew/.linuxbrew/etc/ssh/ssh_config.d/20-systemd-ssh-proxy.conf

chenrui333 avatar Jun 12 '24 01:06 chenrui333

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar Jun 14 '24 03:06 github-actions[bot]

I think this might fix it: https://github.com/systemd/systemd/commit/de0f11d790624138d77f4d383b67c12e0249f54e But the patch does not apply as-is.

Wondering why we are using systemd-stable (version 256) but there is a 256.2 version available ...

iMichka avatar Jul 20 '24 21:07 iMichka

@cho-m I already tried v256.4. unstable and it did not work.

I checked the bottle and the file is registered as:

            "homebrew_version": "4.3.9-307-g4aae003",
            "changed_files": [
              ".bottle/etc/init.d/README",
              ".bottle/etc/ssh/ssh_config.d/20-systemd-ssh-proxy.conf",
              ".bottle/etc/ssh/sshd_config.d/20-systemd-userdb.conf",
              "etc/bash_completion.d/systemctl",
              "lib/pkgconfig/libsystemd.pc",
              "lib/pkgconfig/libudev.pc",
              "lib/rpm/macros.d/macros.systemd",
              "lib/sysctl.d/50-coredump.conf",

It's unclear to me why it's in `.bottle/etc/"

iMichka avatar Aug 01 '24 21:08 iMichka

It's unclear to me why it's in `.bottle/etc/"

I just disabled those extra conf files

      -Dsshconfdir=no
      -Dsshdconfdir=no

The problem is build script uses symlinks when sysconfdir is not under /usr. I guess brew's bottling doesn't expect symlinks inside #{etc}

Alternative is probably manual installation, e.g. (etc/...).unlink then (etc/...).install (lib/...)

https://github.com/systemd/systemd/blob/v256.4/src/ssh-generator/meson.build#L26-L28

                meson.add_install_script(sh, '-c',
                        ln_s.format(libexecdir / 'ssh_config.d' / '20-systemd-ssh-proxy.conf', sshconfdir / '20-systemd-ssh-proxy.conf'))

cho-m avatar Aug 01 '24 21:08 cho-m

guess brew's bottling doesn't expect symlinks inside #{etc}

Yeah maybe that's something to investigate but I don't have much time to check this and understand how brew handles that. I'm fine to disable the option for the time being.

Should we stay on systemd-stable nevertheless?

iMichka avatar Aug 03 '24 21:08 iMichka

Should we stay on systemd-stable nevertheless?

No. The main repo is stable. I added info in commit message:


Switch to main repository as mentioned on v256 release notes:

* Stable releases for version v256 and newer will now be pushed in the
  main repository. The systemd-stable repository will be used for existing
  stable branches (v255-stable and lower), and when they reach EOL it will
  be archived.

cho-m avatar Aug 03 '24 22:08 cho-m

:robot: An automated task has requested bottles to be published to this PR.

github-actions[bot] avatar Aug 04 '24 21:08 github-actions[bot]