miniupnpc 2.2.8

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[chenrui333]

it is weird that the upstream changed the ABI version per patch version bump :(

[fanquake]

We've backported a change to fix this into our 27.x branch, so that can be cherry-picked if required. See: https://github.com/bitcoin/bitcoin/commit/6338f92260523eaf7cd9c89300f4f088f9319b0d.

[SMillerDev]

  /tmp/transmission-cli-20240901-106147-ifhb2y/transmission-4.0.6/libtransmission/port-forwarding-upnp.cc:278:29: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
    278 |         if (UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::data(lanaddr), std::size(lanaddr) - 1) ==
        |             ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from /tmp/transmission-cli-20240901-106147-ifhb2y/transmission-4.0.6/libtransmission/port-forwarding-upnp.cc:19:
  /home/linuxbrew/.linuxbrew/include/miniupnpc/miniupnpc.h:122:1: note: declared here
    122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
        | ^~~~~~~~~~~~~~~~

[chenrui333]

• groestlcoin, https://github.com/Groestlcoin/groestlcoin/commit/8acdf66540834b9f9cf28f16d389e8b6a48516d5
• ppsspp, https://github.com/hrydgard/ppsspp/pull/19335
• transmission, https://github.com/transmission/transmission/pull/6907

[chenrui333]

seeing

==> Downloading https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/1582468167/zip
curl: (56) The requested URL returned error: 410
Error: Download failed: https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/1582468167/zip
Error: Download failed: https://api.github.com/repos/Homebrew/homebrew-core/actions/artifacts/1582468167/zip
Error: Process completed with exit code 1.

in https://github.com/Homebrew/homebrew-core/actions/runs/10761309387/job/29846067801

[github-actions[bot]]

:robot: An automated task has requested bottles to be published to this PR.

[chenrui333]

@chenrui333 can we upstream these patches?

they all exist in the upstream now. (it is just not straight patches for the current release artifacts)