gnome-builder 46.2 (new formula)

[valentinegb]

• [x] Have you followed the guidelines for contributing?
• [x] Have you ensured that your commits follow the commit style guide?
• [x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Adds formula for GNOME Builder v46.2.

[chenrui333]

FAILED: src/libdex-1.a.p/dex-main-scheduler.c.o 
clang -Isrc/libdex-1.a.p -Isrc -I../src -I/usr/local/Cellar/pcre2/10.43/include -I/usr/local/Cellar/glib/2.80.2/include -I/usr/local/Cellar/glib/2.80.2/include/glib-2.0 -I/usr/local/Cellar/glib/2.80.2/lib/glib-2.0/include -I/usr/local/opt/gettext/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -I/private/tmp/gnome-builder--libdex-20240608-20972-dl9yng/libdex-0.6.1/build -fvisibility=hidden -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=gnu11 -O3 -Watomic-alignment -Wcast-align -Wdeclaration-after-statement -Werror=address -Werror=array-bounds -Werror=empty-body -Werror=implicit -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=misleading-indentation -Werror=missing-braces -Werror=missing-include-dirs -Werror=nonnull -Werror=overflow -Werror=pointer-arith -Werror=pointer-to-int-cast -Werror=redundant-decls -Werror=return-type -Werror=sequence-point -Werror=shadow -Werror=strict-prototypes -Werror=trigraphs -Werror=undef -Werror=write-strings -Wformat-nonliteral -Wignored-qualifiers -Wimplicit-function-declaration -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wno-cast-function-type -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wswitch-enum -Wundef -Wuninitialized -Wunused -fno-strict-aliasing -Werror=format-security -Werror=format=2 -FImsvc_recommended_pragmas.h -fstack-protector-strong -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_68 -DG_DISABLE_ASSERT '-DG_LOG_DOMAIN="Dex"' -DDEX_COMPILATION -D_XOPEN_SOURCE -MD -MQ src/libdex-1.a.p/dex-main-scheduler.c.o -MF src/libdex-1.a.p/dex-main-scheduler.c.o.d -o src/libdex-1.a.p/dex-main-scheduler.c.o -c ../src/dex-main-scheduler.c
In file included from ../src/dex-main-scheduler.c:25:

In file included from ../src/dex-fiber-private.h:30:
In file included from ../src/dex-ucontext-private.h:88:
../src/amd64-ucontext.h:6:15: error: conflicting types for 'swapcontext'
extern  int   swapcontext(ucontext_t*, const ucontext_t*);
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ucontext.h:47:6: note: previous declaration is here
int  swapcontext(ucontext_t * __restrict, const ucontext_t * __restrict);
     ^
In file included from ../src/dex-main-scheduler.c:25:
In file included from ../src/dex-fiber-private.h:30:
In file included from ../src/dex-ucontext-private.h:88:
../src/amd64-ucontext.h:7:15: error: conflicting types for 'makecontext'
extern  void  makecontext(ucontext_t*, void(*)(void), int, ...);
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ucontext.h:41:6: note: previous declaration is here
void makecontext(ucontext_t *, void (*)(), int, ...);
     ^
2 errors generated.

[valentinegb]

Upstream issue for build failure: https://gitlab.gnome.org/GNOME/libdex/-/issues/19

[valentinegb]

Upstream issue for build failure: https://gitlab.gnome.org/GNOME/libdex/-/issues/19

This build failure has been resolved in the next version of libdex and the fix has been patched into the version used in this formula. The checks now only fail because of the use of patches.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[valentinegb]

As far as I'm aware, no action needs to be taken on my end, I'm just waiting for this to get merged.

[chenrui333]

what is the status with the patch in this PR?

---

I am seeing this has been closed, https://gitlab.gnome.org/GNOME/libdex/-/issues/19

[valentinegb]

The problem that the patch addresses is fixed in the next version of libdex. I just checked and it looks like the next version has been released now, so we could probably use that version and remove the patch now. (Edit: I've gone ahead and done that ^^)

[valentinegb]

Is the "in progress" tag really appropriate? Since I'm, again, not actively working on this! I'm just waiting to be told what's to happen next.

[fxcoudert]

  Indirect dependencies with linkage:
    cairo
    icu4c
    libxml2
    pango

Please check whether this linkage is expected, and if so, add them as direct dependencies.

[valentinegb]

libxml2 does not appear to be needed on my Apple Silicon Mac running macOS 15, but I'm not sure about other architectures, versions, or on Linux. Also, gettext is needed too on my Mac, but again I'm not sure about in other cases.

[valentinegb]

Hopefully the changes I just made are sufficient, let me know if they aren't ^^'

[valentinegb]

The "build failure" label should probably be removed, since there isn't any build failure to worry about now

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[valentinegb]

As far as I am aware, no action is currently needed on my end, I'm just waiting for this to be merged.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[valentinegb]

I'm not sure what's blocking this PR, but if somebody would let me know I'd be happy to do what I can to get this unblocked ^^

[eleanordoesntcode]

gnome-builder
    * Formulae should not require patches to build. Patches should be submitted and accepted upstream first.

[valentinegb]

Upstream has stated that they will not merge the patch. See here.

[eleanordoesntcode]

Tell me if I'm misreading the issue there, I've just inspected the PR - but if the error is that using gcc 11 on Linux causes an issue, shouldn't we depend on gcc 14 for the Linux build? This is what I seem to understand from the error report.

[valentinegb]

You're right, I've just realized the formula isn't already depending on gcc, I'll try that real quick

[valentinegb]

  gnome-builder
    * Formulae in homebrew/core should not have a Linux-only dependency on GCC.

Suggestions?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[eleanordoesntcode]

not stale, if a maintainer can add "help wanted" it'd be nice

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[valentinegb]

See https://github.com/Homebrew/homebrew-core/pull/174023#issuecomment-2591307031

[valentinegb]

Thanks @cho-m <3

[github-actions[bot]]

:shipit: @chenrui333 has requested bottles to be published to this PR.

[chenrui333]

Thanks @valentinegb and @cho-m, now :shipit:.