homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

odin: add vendor collection and build vendor deps from source

Open laytan opened this issue 1 year ago • 1 comments

Follow up on the discussion in #158496 implementing the discussed resolution from that thread.

All pre-compiled dependencies are first deleted and then built from source.

This is my first time writing a formula so there might be things I did wrong or suboptimally, I read most of the docs and looked at other formulas for inspiration.

I plan on maintaining this if it gets merged + keeping it up-to-date with any upstream updates.

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

laytan avatar Feb 24 '24 23:02 laytan

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Feb 24 '24 23:02 github-actions[bot]

Is there no make target for the vendored libraries?

Only for the ones where we also vendor the original codebase, so for miniaudio and stb you can see I just invoke make in their directories. The bigger stuff doesn't have it.

laytan avatar Feb 26 '24 09:02 laytan

I have made the changes to depend on glfw and raylib formulas and symbolic link them in the right places.

This does require my other PR to add a static library to glfw here https://github.com/Homebrew/homebrew-core/pull/165411 to be merged.

Once that is merged I will rebase this PR and it should all be ok.

laytan avatar Mar 18 '24 18:03 laytan

Thanks @MikeMcQuaid and others for reviewing and discussing in the other PR!

laytan avatar Mar 18 '24 20:03 laytan

:robot: An automated task has requested bottles to be published to this PR.

github-actions[bot] avatar Mar 18 '24 20:03 github-actions[bot]