homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

stellar-core 20.2.0

Open leighmcculloch opened this issue 1 year ago • 2 comments

  • [ ] Have you followed the guidelines for contributing?
  • [ ] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Attempting to fix error from:

  • https://github.com/Homebrew/homebrew-core/pull/161904

leighmcculloch avatar Feb 21 '24 09:02 leighmcculloch

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Feb 21 '24 09:02 github-actions[bot]

  ../hash-xdrs.sh: line 28: sha256sum: command not found
  mkdir -p testdata && cp ../docs/stellar-core_example_validators.cfg testdata/stellar-core_example_validators.cfg
  mkdir -p testdata && cp ../src/history/serialize-tests/stellar-history.testnet.6714239.networkPassphrase.json testdata/stellar-history.testnet.6714239.networkPassphrase.json
  make[1]: *** [main/XDRFilesSha256.cpp] Error 1
  make[1]: *** Waiting for unfinished jobs....
  echo '#include "main/StellarCoreVersion.h"
  
  const std::string STELLAR_CORE_VERSION = "v20.2.0";' > main/StellarCoreVersion.cpp
  make: *** [install-recursive] Error 1

SMillerDev avatar Feb 21 '24 09:02 SMillerDev

A test appears to be failing:

  herder/test/UpgradesTests.cpp:3093: FAILED:
    REQUIRE( upgradesJson == R"({
     "configupgradeinfo" : {
        "configupgradeset" : {
           "updatedEntry" : [
              {
                 "configSettingID" : 0,
                 "contractMaxSizeBytes" : 32768
              }
           ]
        },
        "configupgradesetkey" : {
           "data" : "A2X1x61JPcqp3xe1AxsI6w3fqehhW6iU16Tn5HV32eiPU4K5Q3ayQUPGrHt7nMSvsWFD86wQYI9P6fiJD9kI+w==",
           "nullopt" : false
        }
     },
     "fee" : {
        "data" : 10000,
        "nullopt" : false
     },
     "flags" : {
        "nullopt" : true
     },
     "maxsorobantxsetsize" : {
        "nullopt" : true
     },
     "maxtxsize" : {
        "nullopt" : true
     },
     "reserve" : {
        "nullopt" : true
     },
     "time" : 1666464812,
     "version" : {
        "data" : 20,
        "nullopt" : false
     }
  }
  )" )
  with expansion:
    "{
       "configupgradeinfo" : {
          "configupgradeset" : {
             "updatedEntry" : [
                {
                   "configSettingID" : "CONFIG_SETTING_CONTRACT_MAX_SIZE_BYTES",
                   "contractMaxSizeBytes" : 32768
                }
             ]
          },
          "configupgradesetkey" : {
             "data" :
    "A2X1x61JPcqp3xe1AxsI6w3fqehhW6iU16Tn5HV32eiPU4K5Q3ayQUPGrHt7nMSvsWFD86wQYI9-
    P6fiJD9kI+w==",
             "nullopt" : false
          }
       },
       "fee" : {
          "data" : 10000,
          "nullopt" : false
       },
       "flags" : {
          "nullopt" : true
       },
       "maxsorobantxsetsize" : {
          "nullopt" : true
       },
       "maxtxsize" : {
          "nullopt" : true
       },
       "reserve" : {
          "nullopt" : true
       },
       "time" : 1666464812,
       "version" : {
          "data" : 20,
          "nullopt" : false
       }
    }
    "
    ==
    "{
       "configupgradeinfo" : {
          "configupgradeset" : {
             "updatedEntry" : [
                {
                   "configSettingID" : 0,
                   "contractMaxSizeBytes" : 32768
                }
             ]
          },
          "configupgradesetkey" : {
             "data" :
    "A2X1x61JPcqp3xe1AxsI6w3fqehhW6iU16Tn5HV32eiPU4K5Q3ayQUPGrHt7nMSvsWFD86wQYI9-
    P6fiJD9kI+w==",
             "nullopt" : false
          }
       },
       "fee" : {
          "data" : 10000,
          "nullopt" : false
       },
       "flags" : {
          "nullopt" : true
       },
       "maxsorobantxsetsize" : {
          "nullopt" : true
       },
       "maxtxsize" : {
          "nullopt" : true
       },
       "reserve" : {
          "nullopt" : true
       },
       "time" : 1666464812,
       "version" : {
          "data" : 20,
          "nullopt" : false
       }
    }
    "

Ref: https://github.com/Homebrew/homebrew-core/actions/runs/7987264100/job/21809578743?pr=163521#step:3:14051

I've opened the following issue about the test:

  • https://github.com/stellar/stellar-core/issues/4214

leighmcculloch avatar Feb 26 '24 03:02 leighmcculloch

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 20 '24 00:03 github-actions[bot]

Could someone add the CI-no-fail-fast label to the pull request?

leighmcculloch avatar Mar 21 '24 22:03 leighmcculloch

@SMillerDev I squashed the commits, and so I added a Co-authored-by to the commit message with your details.

The pull request is now ready to review.

leighmcculloch avatar Mar 22 '24 11:03 leighmcculloch

:robot: An automated task has requested bottles to be published to this PR.

github-actions[bot] avatar Mar 22 '24 11:03 github-actions[bot]