rpm 4.19.1.1

[lionelfleury]

RPM 4.19.1.1 can be built on MacOS again. See https://github.com/rpm-software-management/rpm/issues/2807 for details.

• [x] Have you followed the guidelines for contributing?
• [x] Have you ensured that your commits follow the commit style guide?
• [x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [ ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [ ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[github-actions[bot]]

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

[SMillerDev]

That's an interesting error

  ==> /opt/homebrew/Cellar/rpm/4.19.1.1/bin/rpmbuild -ba /private/tmp/rpm-test-20240221-11226-x6pn9k/rpmbuild/SPECS/test.spec
  error: (unknown) field must be present in package: (main package)
  error: (unknown) field must be present in package: (main package)
  error: (unknown) field must be present in package: (main package)
  error: (unknown) field must be present in package: (main package)

[lionelfleury]

that looks very much like a weird linking somewhere...

[markdascher]

Ah, looks like this happens when building it manually too. Looking through the build log, I found this:

lib/gentagtbl.sh: line 74: gawk: command not found

I edited lib/CMakeLists.txt to change AWK=gawk to AWK=awk, and that seemed to fix it. I bet installing gawk would also work.

Reported upstream as rpm-software-management/rpm#2926

[lionelfleury]

added gawk as a build dependency.

[SMillerDev]

Still fails on macOS 12:

  CMake Error at CMakeLists.txt:296 (message):
    required function mkfifoat not found
  Call Stack (most recent call first):
    CMakeLists.txt:305 (chkdef)

[lionelfleury]

that's maybe why it used to be depends_on macos: :ventura in version 4.18.1 ??? should we add something that says macos 13 (ventura) and newer back here?

example: https://raw.githubusercontent.com/Homebrew/homebrew-core/442f9cc511ce6dfe75b96b2c83749d90dde914d2/Formula/r/rpm.rb

reference: https://github.com/rpm-software-management/rpm/issues/2222

[lionelfleury]

added: depends_on macos: :ventura

[SMillerDev]

Could you split the changes to rpm2cpio and rpm into their own commits? I can't automerge it like this.

[lionelfleury]

done

[github-actions[bot]]

:robot: An automated task has requested bottles to be published to this PR.