homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

openjdk@8 1.8.0-402

Open calvinit opened this issue 2 years ago • 9 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

calvinit avatar Feb 19 '24 09:02 calvinit

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Feb 19 '24 09:02 github-actions[bot]

@chenrui333 Hi, NEED HELP: There seems to be some problems with building this PR on MacOS. How did you successfully compile it in the previous version 1.8.0-392? Thank you.

calvinit avatar Feb 19 '24 13:02 calvinit

you need to do a single commit and rebase to the latest master.

chenrui333 avatar Feb 19 '24 13:02 chenrui333

you need to do a single commit and rebase to the latest master.

I mean I will get some clang compiler errors on MacOS platform.

calvinit avatar Feb 19 '24 14:02 calvinit

I mean I will get some clang compiler errors on MacOS platform.

That should be reported upstream, last time it was only sonoma.

SMillerDev avatar Feb 19 '24 15:02 SMillerDev

I mean I will get some clang compiler errors on MacOS platform.

That should be reported upstream, last time it was only sonoma.

How did you solve it last time? Maybe your experience will be helpful to me.

calvinit avatar Feb 20 '24 02:02 calvinit

How did you solve it last time? Maybe your experience will be helpful to me.

Nobody solved it last time, it never worked on Sonoma.

SMillerDev avatar Feb 20 '24 08:02 SMillerDev

How did you solve it last time? Maybe your experience will be helpful to me.

Nobody solved it last time, it never worked on Sonoma.

Currently encountering errors while building C++ (.../jdk8u-jdk8u402-ga/hotspot/src/share/vm/code/compiledIC.cpp:225:15: error: comparison between pointer and integer ('address' (aka 'unsigned char *') and 'bool')). I've tried adding -Wno-pointer-integer-compare diagnostic flag but it's still not working!

According to the official README-builds.html for OpenJDK, it seems to require Xcode 4.5.2 and the "Command line tools". However, the current MacOS system may not be able to download and use such an old version. Is there any other way to proceed?

openjdk8_readme_builds_system_setup

calvinit avatar Feb 20 '24 13:02 calvinit

I'd still like to suggest reporting it to the developers. If they don't have a solution we'll have to disable OpenJDK 8 in Homebrew.

SMillerDev avatar Feb 20 '24 14:02 SMillerDev