homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

Published 20 hours ago • verified publisher icon Homebrew

flight_sql v1.1.19 (new formula)

Open prmoore77 opened this issue 4 months ago • 1 comments

This adds the new Apache Arrow Flight SQL server example formula. The formula installs the flight_sql server CLI executable.

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

prmoore77 avatar Feb 09 '24 15:02 prmoore77

Thanks for contributing to Homebrew! :tada: It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

github-actions[bot] avatar Feb 09 '24 16:02 github-actions[bot]

Hi @bevanjkay - could you kindly re-review? I believe I've addressed your concerns. Thank you.

prmoore77 avatar Feb 29 '24 22:02 prmoore77

@chenrui333 - could you review/approve, perhaps? I would really like to get Flight SQL Server brew installable... Thanks!

prmoore77 avatar Mar 01 '24 15:03 prmoore77

Reading through the build logs it seems to vendor DuckDB which would be against https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae

We use headers from DuckDB's source that do not ship with the brew installation of DuckDB.

prmoore77 avatar Mar 04 '24 19:03 prmoore77

Could we adjust our formula to ship them?

SMillerDev avatar Mar 05 '24 08:03 SMillerDev

Could we adjust our formula to ship them?

I don't think they are intended to be public. I'm using DuckDB internals as part of this product. I usually have to change things upon major releases for that reason, but it is necessary to provide the functionality that this app needs. They don't ship these headers as artifacts...

prmoore77 avatar Mar 05 '24 12:03 prmoore77