homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

hashicorp: deprecate and add caveat

Open iMichka opened this issue 2 years ago • 27 comments

Inform users that we might disable this forumula one day given there will be no more version updates in homebrew-core due to the license change

  • [ ] Have you followed the guidelines for contributing?
  • [ ] Have you ensured that your commits follow the commit style guide?
  • [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

iMichka avatar Aug 14 '23 21:08 iMichka

Not sure if it's necessarily worth elaborating on: but as it stands future releases prior to 1.6.0 will be acceptable, though it's possible there won't be any such release.

Bo98 avatar Aug 15 '23 02:08 Bo98

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 06 '23 00:09 github-actions[bot]

@iMichka gentle ping on that review feedback

fxcoudert avatar Sep 06 '23 08:09 fxcoudert

Done. Sorry for the delay

iMichka avatar Sep 06 '23 19:09 iMichka

Terraform dependents might be resolved when we add OpenTofu, so we could wait a little for that.

Not aware of anything for Consul however so those might have to take the hit.

Bo98 avatar Sep 29 '23 11:09 Bo98

I've re-run the tap_syntax to show the failure so we don't try and fail to auto-merge this for a 5th time.

(It previously wasn't showing because we had removed brew audit from PR checks for a little while while keeping it for merge checks - but I restored it fully as of yesterday.)

Might be worth splitting consul and terraform to their own PRs. We'll need to make a decision on the former, and for the latter it looks like we'll wait for a little bit until OpenTofu make their first release - we already are blocking version bumps so no rush.

Bo98 avatar Sep 29 '23 16:09 Bo98

We may want to remove the livecheck blocks too -- vault 1.15.0 has been released and it's showing up in the output of brew bump.

ZhongRuoyu avatar Sep 30 '23 09:09 ZhongRuoyu

https://github.com/Homebrew/homebrew-core/pull/149678 I created a formula for the opentofu fork

b-reich avatar Oct 05 '23 11:10 b-reich

Perhaps include something to inform those users that want to continue using terraform, etc, that they should use the hashicorp homebrew tap?

https://github.com/hashicorp/homebrew-tap

https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap

thimslugga avatar Oct 08 '23 15:10 thimslugga

These unfortunate dependents also need to be deprecated:

@ZhongRuoyu I'm the lead maintainer of infracost. It shouldn't have a dependency on terraform, so we can update the formula to remove that dependency.

aliscott avatar Oct 08 '23 15:10 aliscott

It shouldn't have a dependency on terraform, so we can update the formula to remove that dependency.

@aliscott Could you open a PR to update infracost's dependency then? Thanks!

ZhongRuoyu avatar Oct 08 '23 17:10 ZhongRuoyu

Perhaps include something to inform those users that want to continue using terraform, etc, that they should use the hashicorp homebrew tap?

https://github.com/hashicorp/homebrew-tap

https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap

We shouldn't link to this directly because:

  • we don't want to be seen to specifically recommend a tap we have no influence over
  • homebrew-core is for open-source software only and we want to be careful pointing to a repository that is not open source software

MikeMcQuaid avatar Oct 08 '23 18:10 MikeMcQuaid

What does this mean for tools like tfenv? Can homebrew be used to install OSS that installs non-OSS software nevertheless?

baggiponte avatar Oct 08 '23 18:10 baggiponte

What does this mean for tools like tfenv? Can homebrew be used to install OSS that installs non-OSS software nevertheless?

If tfenv itself is able to remain open source that's likely fine. I imagine it'll be able to download OpenTofu in the future too anyway.

Bo98 avatar Oct 08 '23 19:10 Bo98

I've moved the formulae that could be deprecated right away to another PR: #150192

iMichka avatar Oct 08 '23 20:10 iMichka

@aliscott Could you open a PR to update infracost's dependency then? Thanks!

Thanks @ZhongRuoyu! - opened one here: https://github.com/Homebrew/homebrew-core/pull/150286

aliscott avatar Oct 09 '23 11:10 aliscott

I am gonna remove all the terraform formulae dependencies on terraform so that we can start the terraform formula deprecation process.

chenrui333 avatar Oct 11 '23 15:10 chenrui333

Hi, all! Thanks for maintaining Homebrew. I am the author of tfmigrate, tfupdate, and tfschema.

Since they have different degrees of dependence on Terraform, I have commented on supplementary information in each pull request. https://github.com/Homebrew/homebrew-core/pull/150568#issuecomment-1758831866 https://github.com/Homebrew/homebrew-core/pull/150566#issuecomment-1758823693 https://github.com/Homebrew/homebrew-core/pull/150567#issuecomment-1758820948

minamijoyo avatar Oct 12 '23 02:10 minamijoyo

I temporarily replaced the livecheck blocks for consul and terraform with #skip calls (https://github.com/Homebrew/homebrew-core/pull/151264) while this PR is being worked through. We should remove those livecheck blocks here, so livecheck will automatically skip these formulae as deprecated (like the other deprecated Hashicorp formulae).

samford avatar Oct 16 '23 20:10 samford

  envconsul
    * Dependency 'consul' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'consul' or deprecate it and all of its dependents.
  fabio
    * Dependency 'consul' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'consul' or deprecate it and all of its dependents.
  stolon
    * Dependency 'consul' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'consul' or deprecate it and all of its dependents.

envconsul: 20 installs this month fabio: 5 installs this month stolon: 17 installs this month

I think we can deprecate them, since there is no core-eligible replacement for consul

SMillerDev avatar Nov 13 '23 13:11 SMillerDev

this is syntax PR, the dependency swap should be done in a different PR to actually test out the formula run.

chenrui333 avatar Nov 14 '23 15:11 chenrui333

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Dec 06 '23 00:12 github-actions[bot]

Rebased and added some comments / updates. Still some work to do here ...

iMichka avatar Dec 07 '23 21:12 iMichka

FYI, HC vault got forked into openbao, https://github.com/openbao/openbao, that would help with vault deprecation.

chenrui333 avatar Dec 09 '23 21:12 chenrui333

I know a bit off-topic. Is there an replacement project for packer?

b-reich avatar Dec 24 '23 20:12 b-reich

Is there an replacement project for packer?

I dont think so

chenrui333 avatar Jan 05 '24 17:01 chenrui333

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jan 27 '24 00:01 github-actions[bot]

This should be good now, I took care of all the dependencies.

iMichka avatar Apr 04 '24 21:04 iMichka

Just a nit, but since this has already happened we can probably remove all the future tense language.

p-linnane avatar Apr 04 '24 21:04 p-linnane

Just a nit, but since this has already happened we can probably remove all the future tense language.

Done; this pull request feels so old now :)

iMichka avatar Apr 04 '24 21:04 iMichka