homebrew-core
homebrew-core copied to clipboard
hashicorp: deprecate and add caveat
Inform users that we might disable this forumula one day given there will be no more version updates in homebrew-core due to the license change
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you ensured that your commits follow the commit style guide?
- [ ] Have you checked that there aren't other open pull requests for the same formula update/change?
- [ ] Have you built your formula locally with
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? - [ ] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [ ] Does your build pass
brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
Not sure if it's necessarily worth elaborating on: but as it stands future releases prior to 1.6.0 will be acceptable, though it's possible there won't be any such release.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
@iMichka gentle ping on that review feedback
Done. Sorry for the delay
Terraform dependents might be resolved when we add OpenTofu, so we could wait a little for that.
Not aware of anything for Consul however so those might have to take the hit.
I've re-run the tap_syntax to show the failure so we don't try and fail to auto-merge this for a 5th time.
(It previously wasn't showing because we had removed brew audit from PR checks for a little while while keeping it for merge checks - but I restored it fully as of yesterday.)
Might be worth splitting consul and terraform to their own PRs. We'll need to make a decision on the former, and for the latter it looks like we'll wait for a little bit until OpenTofu make their first release - we already are blocking version bumps so no rush.
We may want to remove the livecheck blocks too -- vault 1.15.0 has been released and it's showing up in the output of brew bump.
https://github.com/Homebrew/homebrew-core/pull/149678 I created a formula for the opentofu fork
Perhaps include something to inform those users that want to continue using terraform, etc, that they should use the hashicorp homebrew tap?
https://github.com/hashicorp/homebrew-tap
https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap
These unfortunate dependents also need to be deprecated:
@ZhongRuoyu I'm the lead maintainer of infracost. It shouldn't have a dependency on terraform, so we can update the formula to remove that dependency.
It shouldn't have a dependency on terraform, so we can update the formula to remove that dependency.
@aliscott Could you open a PR to update infracost's dependency then? Thanks!
Perhaps include something to inform those users that want to continue using terraform, etc, that they should use the hashicorp homebrew tap?
https://github.com/hashicorp/homebrew-tap
https://www.hashicorp.com/blog/announcing-hashicorp-homebrew-tap
We shouldn't link to this directly because:
- we don't want to be seen to specifically recommend a tap we have no influence over
- homebrew-core is for open-source software only and we want to be careful pointing to a repository that is not open source software
What does this mean for tools like tfenv? Can homebrew be used to install OSS that installs non-OSS software nevertheless?
What does this mean for tools like tfenv? Can homebrew be used to install OSS that installs non-OSS software nevertheless?
If tfenv itself is able to remain open source that's likely fine. I imagine it'll be able to download OpenTofu in the future too anyway.
I've moved the formulae that could be deprecated right away to another PR: #150192
@aliscott Could you open a PR to update infracost's dependency then? Thanks!
Thanks @ZhongRuoyu! - opened one here: https://github.com/Homebrew/homebrew-core/pull/150286
I am gonna remove all the terraform formulae dependencies on terraform so that we can start the terraform formula deprecation process.
Hi, all! Thanks for maintaining Homebrew. I am the author of tfmigrate, tfupdate, and tfschema.
Since they have different degrees of dependence on Terraform, I have commented on supplementary information in each pull request. https://github.com/Homebrew/homebrew-core/pull/150568#issuecomment-1758831866 https://github.com/Homebrew/homebrew-core/pull/150566#issuecomment-1758823693 https://github.com/Homebrew/homebrew-core/pull/150567#issuecomment-1758820948
I temporarily replaced the livecheck blocks for consul and terraform with #skip calls (https://github.com/Homebrew/homebrew-core/pull/151264) while this PR is being worked through. We should remove those livecheck blocks here, so livecheck will automatically skip these formulae as deprecated (like the other deprecated Hashicorp formulae).
envconsul
* Dependency 'consul' is deprecated but has un-deprecated dependents. Either
un-deprecate 'consul' or deprecate it and all of its dependents.
fabio
* Dependency 'consul' is deprecated but has un-deprecated dependents. Either
un-deprecate 'consul' or deprecate it and all of its dependents.
stolon
* Dependency 'consul' is deprecated but has un-deprecated dependents. Either
un-deprecate 'consul' or deprecate it and all of its dependents.
envconsul: 20 installs this month fabio: 5 installs this month stolon: 17 installs this month
I think we can deprecate them, since there is no core-eligible replacement for consul
this is syntax PR, the dependency swap should be done in a different PR to actually test out the formula run.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Rebased and added some comments / updates. Still some work to do here ...
FYI, HC vault got forked into openbao, https://github.com/openbao/openbao, that would help with vault deprecation.
I know a bit off-topic. Is there an replacement project for packer?
Is there an replacement project for packer?
I dont think so
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This should be good now, I took care of all the dependencies.
Just a nit, but since this has already happened we can probably remove all the future tense language.
Just a nit, but since this has already happened we can probably remove all the future tense language.
Done; this pull request feels so old now :)