homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

gnuradio 3.10.4.0

Open chenrui333 opened this issue 3 years ago • 5 comments

Created by brew bump


Created with brew bump-formula-pr.

resource blocks may require updates.

chenrui333 avatar Sep 19 '22 22:09 chenrui333

  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:24:24: error: use of undeclared identifier 'std'
      block_interleaving(std::vector<size_t> interleaver_indices);
                         ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:24:36: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      block_interleaving(std::vector<size_t> interleaver_indices);
                                     ^~~~~~
                                     sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:24:42: error: expected expression
      block_interleaving(std::vector<size_t> interleaver_indices);
                                           ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:26:5: error: unknown type name 'size_t'
      size_t interleaver_length() { return _interleaver_indices.size(); };
      ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:27:5: error: use of undeclared identifier 'std'
      std::vector<size_t> interleaver_indices() { return _interleaver_indices; };
      ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:27:17: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      std::vector<size_t> interleaver_indices() { return _interleaver_indices; };
                  ^~~~~~
                  sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:27:23: error: expected expression
      std::vector<size_t> interleaver_indices() { return _interleaver_indices; };
                        ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:28:5: error: use of undeclared identifier 'std'
      std::vector<size_t> deinterleaver_indices() { return _deinterleaver_indices; };
      ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:28:17: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      std::vector<size_t> deinterleaver_indices() { return _deinterleaver_indices; };
                  ^~~~~~
                  sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:28:23: error: expected expression
      std::vector<size_t> deinterleaver_indices() { return _deinterleaver_indices; };
                        ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:47:5: error: use of undeclared identifier 'std'
      std::vector<size_t> _interleaver_indices;
      ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:47:17: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      std::vector<size_t> _interleaver_indices;
                  ^~~~~~
                  sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:47:23: error: expected expression
      std::vector<size_t> _interleaver_indices;
                        ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:48:5: error: use of undeclared identifier 'std'
      std::vector<size_t> _deinterleaver_indices;
      ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:48:17: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      std::vector<size_t> _deinterleaver_indices;
                  ^~~~~~
                  sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:48:23: error: expected expression
      std::vector<size_t> _deinterleaver_indices;
                        ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:50:40: error: use of undeclared identifier 'std'
      void set_interleaver_indices(const std::vector<size_t>& interleaver_indices);
                                         ^
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:50:52: error: use of undeclared identifier 'size_t'; did you mean 'sizeof'?
      void set_interleaver_indices(const std::vector<size_t>& interleaver_indices);
                                                     ^~~~~~
                                                     sizeof
  /tmp/gnuradio-20220919-55509-aztp9x/gnuradio-3.10.4.0/gr-blocks/lib/../include/gnuradio/blocks/blockinterleaving.h:50:58: error: expected expression
      void set_interleaver_indices(const std::vector<size_t>& interleaver_indices);
                                                           ^
  fatal error: too many errors emitted, stopping now [-ferror-limit=]
  20 errors generated.

chenrui333 avatar Sep 19 '22 23:09 chenrui333

blockinterleaving.h is missing include <cstddef> and include <vector>. I'll add a patch here and upstream it if it works.

danielnachun avatar Sep 20 '22 03:09 danielnachun

That seems to work. Just needs the long timeout label.

carlocab avatar Sep 20 '22 17:09 carlocab

Let's try to switch to an upstream patch before running this again. CC @danielnachun

carlocab avatar Sep 21 '22 12:09 carlocab

cstddef include still needs to be upstreamed. vector was added in https://github.com/gnuradio/gnuradio/commit/463c3477549b26b32d9b73eef30044e97c4eee64

cho-m avatar Sep 22 '22 21:09 cho-m

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar Sep 24 '22 22:09 github-actions[bot]

Someone beat us to it for upstreaming cstddef: https://github.com/gnuradio/gnuradio/pull/6188. I will change this to use the upstream commit for <vector>.

danielnachun avatar Sep 25 '22 19:09 danielnachun

Actually trying to have a patch to add <cstddef> on top of another patch to add <vector> seems a bit tricky. Since <cstddef> has already been upstreamed, I think it might be better to just add links to the relevant upstream commit for <vector> and the PR for <cstddef> because they will both be added in the next release after which the patch can be dropped. Does this sound good?

danielnachun avatar Sep 25 '22 19:09 danielnachun

Ok with me. Or maybe we could just add -include flags to CXXFLAGS.

carlocab avatar Sep 27 '22 02:09 carlocab

:robot: A scheduled task has triggered a merge.

BrewTestBot avatar Oct 04 '22 10:10 BrewTestBot