homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

evince 43.0

Open chenrui333 opened this issue 2 years ago • 9 comments

Created with brew bump-formula-pr.

chenrui333 avatar Sep 18 '22 19:09 chenrui333

  meson.build:521:6: ERROR: Program 'gtk-update-icon-cache' not found or not executable

chenrui333 avatar Sep 18 '22 19:09 chenrui333

This should depend on gtk+4 now instead of gtk+3.

danielnachun avatar Sep 18 '22 20:09 danielnachun

This should depend on gtk+4 now instead of gtk+3.

I guess it requires gtk+3? gtk_dep = dependency('gtk+-3.0', version: gtk_req_version)

chenrui333 avatar Sep 18 '22 21:09 chenrui333

relates to https://github.com/GNOME/evince/commit/48bebe4d17f4e65778a72d7eac85b9961366e51c

chenrui333 avatar Sep 18 '22 21:09 chenrui333

Looks like meson core support issue, related PR, https://github.com/mesonbuild/meson/pull/8272

chenrui333 avatar Sep 18 '22 21:09 chenrui333

Raise a PR of deprecating gtk2, for this PR, I think we can disable the cache update.

chenrui333 avatar Sep 18 '22 22:09 chenrui333

A better solution is to have the gtk4 recipe build two binary packages:

  • gtk4
  • gtk-update-icon-cache

And the latter would contain gtk4-update-icon-cache as well as a symlink for gtk-update-icon-cache.

The non-upstream gtk3-update-icon-cache name isn't needed. Neither gtk2 nor gtk3 nor gtk4 binary packages would have an update-icon-cache binary of any description, but they would depend on the "gtk-update-icon-cache" binary package.

There would only ever be one binary, plus one alias, and it would be shared between all 3 packages without conflicting.

eli-schwartz avatar Sep 19 '22 00:09 eli-schwartz

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar Sep 21 '22 00:09 github-actions[bot]

What's a bit disappointing is that Meson's gnome.post_install() checks for DESTDIR at the end while GNOME's post-install scripts would check at the beginning.

Even though none of the commands are going to be run (i.e. DESTDIR=/), the build fails on finding the command.

https://mesonbuild.com/Gnome-module.html#gnomepost_install

If DESTDIR is specified during installation all scripts will be skipped.

cho-m avatar Sep 22 '22 00:09 cho-m

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar Sep 24 '22 22:09 github-actions[bot]

continuing with 43.1

chenrui333 avatar Dec 05 '22 01:12 chenrui333