homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

sqlcmd 0.9.1 (new formula)

Open stuartpa opened this issue 2 years ago • 7 comments

The Microsoft SQL Server engineering team have re-written (and made OSS) the CLI for SQL Server (sqlcmd) in golang to enable it to be cross platform (and require no dependencies). The sqlcmd utlity has been installed 100s of millions of times. We would like to make sqlcmd available for all package managers on all platforms. This PR makes it available in brew.

https://github.com/microsoft/go-sqlcmd https://docs.microsoft.com/en-us/sql/tools/sqlcmd-utility https://docs.microsoft.com/en-us/sql/tools/go-sqlcmd-utility

  • [Y] Have you followed the guidelines for contributing?
  • [Y] Have you ensured that your commits follow the commit style guide?
  • [Y] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [Y] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [Y] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [Y] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Updated: brew audit --strict now passes

stuartpa avatar Sep 07 '22 11:09 stuartpa

@stuartpa QQ, looks like 0.9.1, 0.9.2, 0.9.3 three releases are pointing to the same commit, any reason why?

chenrui333 avatar Sep 16 '22 04:09 chenrui333

@stuartpa QQ, looks like 0.9.1, 0.9.2, 0.9.3 three releases are pointing to the same commit, any reason why?

I'm not seeing 0.9.2, 0.9.3 at:

https://github.com/microsoft/go-sqlcmd/releases

I'm guessing you did see them, and this was probably someone on my team testing releases (and now .2 and .3 have been cleaned up)

stuartpa avatar Sep 20 '22 12:09 stuartpa

@stuartpa QQ, looks like 0.9.1, 0.9.2, 0.9.3 three releases are pointing to the same commit, any reason why?

I'm not seeing 0.9.2, 0.9.3 at:

https://github.com/microsoft/go-sqlcmd/releases

I'm guessing you did see them, and this was probably someone on my team testing releases (and now .2 and .3 have been cleaned up)

We have got to the bottom of this, someone was testing the pipeline process in a local branch, and tags got pushed to main, we are clearing this up. v0.9.1 is still the latest.

Issue on the go-sqlcmd sideL

https://github.com/microsoft/go-sqlcmd/issues/137

stuartpa avatar Sep 20 '22 15:09 stuartpa

Why the 4 notifications?

SMillerDev avatar Sep 22 '22 06:09 SMillerDev

Why the 4 notifications?

The "re-request review" circular icon did not disappear when I clicked it, so I didn't know if it was working. As a user this feels like a bug in github, I am not getting any feedback as to why the circular icon is not changing to the orange dot. If this is a bug, let me know and I'll file a bug against github.

stuartpa avatar Sep 22 '22 08:09 stuartpa

Yeah, that seems like a bug in GitHub

SMillerDev avatar Sep 22 '22 09:09 SMillerDev

Yeah, that seems like a bug in GitHub

Thanks, I've filed a bug report with github

https://support.github.com/ticket/personal/0/1805799

stuartpa avatar Sep 22 '22 09:09 stuartpa

Yeah, that seems like a bug in GitHub

Thanks, I've filed a bug report with github

https://support.github.com/ticket/personal/0/1805799

Thanks!

chenrui333 avatar Sep 23 '22 14:09 chenrui333

:shipit: @chenrui333 has triggered a merge.

BrewTestBot avatar Sep 23 '22 14:09 BrewTestBot

@stuartpa, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

chenrui333 avatar Sep 23 '22 14:09 chenrui333