homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

throttled_formulae: add testkube

Open bayandin opened this issue 1 year ago • 6 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ ] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ ] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

testkube gets several releases per day: https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+testkube+is%3Aclosed Quite often, we have several open PRs with it. I suggest throttling it a little

bayandin avatar Aug 10 '22 11:08 bayandin

We'll need to get upstream to switch to @dawidd6's action. I don't think @mislav's action currently handles throttled formulae.

carlocab avatar Aug 10 '22 11:08 carlocab

They even got two releases on the exact same commit: https://github.com/kubeshop/testkube/releases (1.4.12 and 1.4.13).

On the other hand, when minor/dot releases bring so few changes (for example https://github.com/kubeshop/testkube/compare/v1.4.13...v1.4.14), is it conceivable that if all tests are greens and only for minor/dot releases (here for example any 1.4.x release), brewtestbot gives itself an approval and a merge? This would avoid to have several opened at once, while allowing to have latest release, which might be bugfixes or security fixes that can't be obtained otherwise. The throttle can prevent those bug/security releases to be updated.

(Another issue I happened to notice with throttled formulas is for example some might slow down or even stop the development for a while and users can't get the latest release because that's not a good multiple. See for example quicktype formula, stuck with an update at x+1 for now a very long time, but can't be updated due to throttle).

Porkepix avatar Aug 10 '22 12:08 Porkepix

This would avoid to have several opened at once, while allowing to have latest release, which might be bugfixes or security fixes that can't be obtained otherwise.

Regarding the first part, I don't think so; building a package could take more time than cutting a release (and creating a PR).

(Another issue I happened to notice with throttled formulas is for example some might slow down or even stop the development for a while and users can't get the latest release because that's not a good multiple. See for example quicktype formula, stuck with an update at x+1 for now a very long time, but can't be updated due to throttle).

This can be addressed with throttle logic, if there were no releases for some time (for a week, for example) — stop complaining

bayandin avatar Aug 10 '22 12:08 bayandin

brewtestbot gives itself an approval and a merge?

Never gonna make that mistake again: https://brew.sh/2021/04/21/security-incident-disclosure/

SMillerDev avatar Aug 10 '22 14:08 SMillerDev

A lot of these quick releases appear to be CI tweaks. I'm not entirely convinced it'll necessarily be like that long term.

Bo98 avatar Aug 10 '22 16:08 Bo98

Ok I've figured it out: some CI changes are being worked on at https://github.com/kubeshop/testkube/commits/update-ci-choco but they're testing the full release flow. Really those should not be actually be public releases (only those on main), but if we ignore those releases the actual number of proper releases is more normal.

Bo98 avatar Aug 10 '22 18:08 Bo98

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 01 '22 00:09 github-actions[bot]