solo2-cli 0.2.0 (new formula)

[b-reich]

• [x] Have you followed the guidelines for contributing?
• [x] Have you ensured that your commits follow the commit style guide?
• [x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[b-reich]

not sure why this happens sometimes on the 12-arm64 image... its no deterministic in my eyes

  ==> /opt/homebrew/Cellar/solo2-cli/0.2.0/bin/solo2 ls
  
  Error: solo2-cli: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: nil
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.16.2/lib/minitest/assertions.rb:183:in `assert'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.16.2/lib/minitest/assertions.rb:218:in `assert_equal'

also not sure which deps needed to work on linux

  error: failed to run custom build command for `pcsc-sys v1.2.0`

Caused by:
  process didn't exit successfully: `/tmp/solo2-cli-20220808-12424-1yuxx7j/solo2-cli-0.2.0/target/release/build/pcsc-sys-2f2bc8c47220d999/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=LIBPCSCLITE_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=LIBPCSCLITE_STATIC

this sould be fix with with pcsc-lite https://github.com/Homebrew/homebrew-core/blob/68832317faaf64bfc23eae7a0eb4a75b9ddf7ea9/Formula/solo2-cli.rb#L17-L21

[b-reich]

@SMillerDev do you have an idea why the test sometimes fail on 12-arm64?

[SMillerDev]

It seems it times out

[b-reich]

@SMillerDev I am done :)

[chenrui333]

Merge branch 'Homebrew:master' into solo2-cli

Can you rebase to the latest master rather doing the branch merge?

[b-reich]

Merge branch 'Homebrew:master' into solo2-cli

Can you rebase to the latest master rather doing the branch merge?

done :) Ahh I just use the github integrated function... Is this fine? Or should I do a proper rebase?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[b-reich]

@SMillerDev @chenrui333 do you have any idea why the test times out some times?

[SMillerDev]

In this case it didn't time out, it failed on ARM on Big Sur

[b-reich]

In this case it didn't time out, it failed on ARM on Big Sur

  Error: solo2-cli: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: nil
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.16.2/lib/minitest/assertions.rb:183:in `assert'
  /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/minitest-5.16.2/lib/minitest/assertions.rb:218:in `assert_equal'
  /opt/homebrew/Library/Homebrew/formula_assertions.rb:26:in `shell_output'
  /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/solo2-cli.rb:37:in `block in <class:Solo2Cli>'
  /opt/homebrew/Library/Homebrew/formula.rb:2256:in `block (3 levels) in run_test'
  /opt/homebrew/Library/Homebrew/utils.rb:605:in `with_env'
  /opt/homebrew/Library/Homebrew/formula.rb:2255:in `block (2 levels) in run_test'
  /opt/homebrew/Library/Homebrew/formula.rb:935:in `with_logging'
  /opt/homebrew/Library/Homebrew/formula.rb:2254:in `block in run_test'
  /opt/homebrew/Library/Homebrew/mktemp.rb:77:in `block in run'
  /opt/homebrew/Library/Homebrew/mktemp.rb:77:in `chdir'
  /opt/homebrew/Library/Homebrew/mktemp.rb:77:in `run'
  /opt/homebrew/Library/Homebrew/formula.rb:2531:in `mktemp'
  /opt/homebrew/Library/Homebrew/formula.rb:2248:in `run_test'
  /opt/homebrew/Library/Homebrew/test.rb:43:in `block in <main>'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/timeout.rb:33:in `catch'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/timeout.rb:33:in `catch'
  /opt/homebrew/Library/Homebrew/vendor/portable-ruby/2.6.8_1/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
  /opt/homebrew/Library/Homebrew/test.rb:48:in `<main>'

looks like a timeout for me

result is nil because the timeout kill the process

[b-reich]

@SMillerDev @chenrui333 I need support for this PR.

[SMillerDev]

With what?

[b-reich]

With what?

Sometimes the tests seem to run into timeouts. Not sure why.

[SMillerDev]

I'm not sure why either, clearly sometimes solo2-cli sometimes takes too long to execute.

[b-reich]

@SMillerDev is there a way to extend the timeout period?

[SMillerDev]

No, 15 minutes should be more than enough to run a simple test.

[b-reich]

No, 15 minutes should be more than enough to run a simple test.

Its not a problem of CI Task. Also saw this behavior on my local machine. I think this a problem in the homebrew assert method. This timeout is not 15 minutes

[SMillerDev]

It could be, but with 6296 Formulae in Homebrew core it seems unlikely that it only fails here.

[b-reich]

https://github.com/Homebrew/brew/blob/823f663ab478cc3d1cc6a691ba8b2210fb5486cc/Library/Homebrew/test.rb#L17

There should be a much bigger timeout