homebrew-core
homebrew-core copied to clipboard
wasm-micro-runtime 1.0.0 (new formula)
- [x] Have you followed the guidelines for contributing?
- [x] Have you ensured that your commits follow the commit style guide?
- [x] Have you checked that there aren't other open pull requests for the same formula update/change?
- [x] Have you built your formula locally with
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? - [x] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [x] Does your build pass
brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
I would like to have an alias to to this formula called wamr, but I have no idea how to do that.
I would like to have an alias to to this formula called wamr, but I have no idea how to do that.
You can make a link in Aliases
It looks like this builds its own LLVM, and possibly a (static) libuv.
https://github.com/bytecodealliance/wasm-micro-runtime/blob/7be0d385a62c72f53449bafdafd187c98be17894/product-mini/platforms/darwin/CMakeLists.txt#L101
https://github.com/bytecodealliance/wasm-micro-runtime/blob/7be0d385a62c72f53449bafdafd187c98be17894/product-mini/platforms/darwin/build_llvm.sh
This makes it unsuitable for Homebrew/core: https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae
It may require LLVM if someone wanted to compile in the JIT as well to the runtime, but by default it doesn't. The current formula doesn't require LLVM (although someone can pass in CMake options to enable it). Does this make it still unsuitable for core?
Let's deactivate those features explicitly then to make sure we don't pull in dependencies we don't want. If we can delete the extra scripts that build LLVM before calling CMake, then better.
What about libuv? Is that not used?
Libuv is used only in case of a certain flag for UVWASI, and I have disabled that explicitly as well as the LLVM jit backend.
We are waiting on upstream to tag a proper Git tag right?
They already have proper Git tags. At minimum we just want feedback that reversing their version into yyyy-mm-dd and shipping their software that way is reasonable.
In the quick meantime, WAMR is adding support for SemVer: https://github.com/bytecodealliance/wasm-micro-runtime/pull/1374
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
The SemVer versioning changes have been merged upstream, but there is no release yet following SemVer versioning, we are waiting for that, just asked upstream when can we expect a release.
FYI: WAMR 1.0.0 has been released, just updated the formula.
@carlocab @alebcay can you please have a look at this one?
:shipit: @chenrui333 has triggered a merge.
@bonifaido, thanks for your contribution to Homebrew! 🎉 🥇
Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!