homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

wasm-micro-runtime 1.0.0 (new formula)

Open bonifaido opened this issue 3 years ago • 13 comments

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

bonifaido avatar Aug 04 '22 11:08 bonifaido

I would like to have an alias to to this formula called wamr, but I have no idea how to do that.

bonifaido avatar Aug 04 '22 11:08 bonifaido

I would like to have an alias to to this formula called wamr, but I have no idea how to do that.

You can make a link in Aliases

SMillerDev avatar Aug 04 '22 12:08 SMillerDev

It looks like this builds its own LLVM, and possibly a (static) libuv.

https://github.com/bytecodealliance/wasm-micro-runtime/blob/7be0d385a62c72f53449bafdafd187c98be17894/product-mini/platforms/darwin/CMakeLists.txt#L101

https://github.com/bytecodealliance/wasm-micro-runtime/blob/7be0d385a62c72f53449bafdafd187c98be17894/product-mini/platforms/darwin/build_llvm.sh

This makes it unsuitable for Homebrew/core: https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae

carlocab avatar Aug 04 '22 15:08 carlocab

It may require LLVM if someone wanted to compile in the JIT as well to the runtime, but by default it doesn't. The current formula doesn't require LLVM (although someone can pass in CMake options to enable it). Does this make it still unsuitable for core?

bonifaido avatar Aug 05 '22 08:08 bonifaido

Let's deactivate those features explicitly then to make sure we don't pull in dependencies we don't want. If we can delete the extra scripts that build LLVM before calling CMake, then better.

What about libuv? Is that not used?

carlocab avatar Aug 05 '22 08:08 carlocab

Libuv is used only in case of a certain flag for UVWASI, and I have disabled that explicitly as well as the LLVM jit backend.

bonifaido avatar Aug 05 '22 09:08 bonifaido

We are waiting on upstream to tag a proper Git tag right?

bonifaido avatar Aug 11 '22 08:08 bonifaido

They already have proper Git tags. At minimum we just want feedback that reversing their version into yyyy-mm-dd and shipping their software that way is reasonable.

carlocab avatar Aug 11 '22 08:08 carlocab

In the quick meantime, WAMR is adding support for SemVer: https://github.com/bytecodealliance/wasm-micro-runtime/pull/1374

bonifaido avatar Aug 12 '22 06:08 bonifaido

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 02 '22 13:09 github-actions[bot]

The SemVer versioning changes have been merged upstream, but there is no release yet following SemVer versioning, we are waiting for that, just asked upstream when can we expect a release.

bonifaido avatar Sep 02 '22 13:09 bonifaido

FYI: WAMR 1.0.0 has been released, just updated the formula.

bonifaido avatar Sep 12 '22 10:09 bonifaido

@carlocab @alebcay can you please have a look at this one?

bonifaido avatar Sep 21 '22 07:09 bonifaido

:shipit: @chenrui333 has triggered a merge.

BrewTestBot avatar Sep 24 '22 18:09 BrewTestBot

@bonifaido, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

chenrui333 avatar Sep 24 '22 18:09 chenrui333