homebrew-core
homebrew-core copied to clipboard
gdcm,[email protected]: migrate to [email protected]
- [x] Have you followed the guidelines for contributing?
- [x] Have you ensured that your commits follow the commit style guide?
- [x] Have you checked that there aren't other open pull requests for the same formula update/change?
- [ ] Have you built your formula locally with
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting? - [ ] Is your test running fine
brew test <formula>, where<formula>is the name of the formula you're submitting? - [ ] Does your build pass
brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?
Seems to crash when it tries to run vtkpython.
I was looking into vtk and hit same issue, which I found was lack of Python 3.10 support in current stable release. At least for vtk v9, there is a fix https://gitlab.kitware.com/vtk/vtk/-/merge_requests/8738 that can either be patched or will be available in 9.2.0.
We could try to backport it to v8 or just keep on [email protected].
I don't mind keeping it on [email protected]. But if you're keen to backport the patch, I'm okay with that too.
I also think [email protected] is fine given that we are trying to re-deprecate (and ultimately remove) [email protected]
I would like to get [email protected] migrated to jpeg-turbo since that should be a drop-in. Maybe at same time as itk.
For current vtk, I am looking into backporting Python 3.10 patch with something like following, but need to check how bad dependency tree migration is (e.g. opencv, gdal, ...). Particularly trying to avoid pulling in formulae with gobject-introspection, if possible.
# Fix vtkpython support for Python 3.10. Remove in the next release.
# First patch backports part of older commit so we can directly patch in upstream commit.
patch :DATA
patch do
url "https://gitlab.kitware.com/vtk/vtk/-/commit/3eea0e12acfb608a76d6ae36fb36566a4a6b0e9b.diff"
sha256 "1c1c4622a58f8c852d196759c8d9036e4d513a5ebe16fe0bfa14583832886572"
end
...
__END__
diff --git a/Documentation/release/dev/python-3.10-wheels.md b/Documentation/release/dev/python-3.10-wheels.md
new file mode 100644
index 0000000000000000000000000000000000000000..f4e81411c73f30724ad420ccb7f3c6c07a6f8e3d
--- /dev/null
+++ b/Documentation/release/dev/python-3.10-wheels.md
@@ -0,0 +1,7 @@
+## Python 3.10 wheels
+
+VTK now generates Python 3.10 wheels. Note that `vtkpython` and other tools
+using `vtkPythonInterpreter` still do not support the new initialization
+behaviors introduced in Python 3.10. See [this issue][vtk-python-3.10-support].
+
+[vtk-python-3.10.support]: https://gitlab.kitware.com/vtk/vtk/-/issues/18317
Closing in favor of #107657