homebrew-core
homebrew-core copied to clipboard
shaderc v2022.1 (new formula)
- [X] Have you followed the guidelines for contributing?
- [X] Have you ensured that your commits follow the commit style guide?
- [X] Have you checked that there aren't other open pull requests for the same formula update/change?
- [X] Have you built your formula locally with
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting? - [X] Is your test running fine
brew test <formula>
, where<formula>
is the name of the formula you're submitting? - [X] Does your build pass
brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?
Succeeds #39526.
This formula fails brew audit --online --strict
due to requiring specific revisions of its resources (so setting a head branch for each would be inappropriate); not sure how to resolve that.
You should still set a branch despite the specific revision
I had to create separate stable do
and head do
branches to ensure stable builds get the specified revisions. Unfortunately, it looks like I have to have head
depend on whatever's in the resources' master
branches to satisfy brew audit
, rather than using the revisions specified in known_good.json
.
Believe this should all be in a good state to move forward now; anything left I can do?
I just rebased this without changes, but note that @alebcay had previously approved. Is there anything blocking merge at this point?
Anything blocking this?
:shipit: @SMillerDev has triggered a merge.