libsndfile: add mpeg dependencies

[dyfer]

• [x] Have you followed the guidelines for contributing?
• [x] Have you ensured that your commits follow the commit style guide?
• [x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Libsndfile v 1.1.0 (currently in homebrew) supports mpeg formats. That functionality is on by default, but it is only activated during build if lame and mpg123 libraries are found.

I've added these libraries as dependencies, so that libsndfile gets built with mpeg support.

% brew install --build-from-source libsndfile --verbose
(...)
checking for lame/lame.h... yes
checking for library containing lame_set_VBR_q... -lmp3lame
checking for libmpg123 >= 1.25.10 ... yes
(...)
   External MPEG Lame/MPG123 : ........... yes

Please let me know if there's anything missing in this PR.

[dyfer]

After seeing failures with the Linux CI, I've added Python as a dependency for that platform. This was a bit of a shot in the dark... please let me know if this is an acceptable solution.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[dyfer]

@SMillerDev I just wanted to check in whether I can help with anything regarding this PR

[SMillerDev]

CI should be fixed, otherwise we can't merge this.

[dyfer]

I was able to build libsndfile from this PR using homebrew on Ubuntu 20.04. Are you sure that the CI failure is related to this PR? IIUC here's the relevant output:

==> brew linkage --cached --test --strict libgig
==> FAILED
Full linkage --cached --test --strict libgig output
  Undeclared dependencies with linkage:
    util-linux
Truncated linkage --cached --test --strict libgig output
  Warning: Undeclared dependencies with linkage:
    util-linux

I seem to get the same output of brew linkage --cached --test --strict libgig when using libsndfile from the master branch.

[dyfer]

@SMillerDev is there any way I can help with fixing the CI?

[SMillerDev]

I would hope so, it's your pull request.

[dyfer]

@SMillerDev as I pointed out previously, I don't understand how my change causes the CI failures. Moreover, the same failure occurs if I build libsndfile from the master branch. I'd appreciate any guidance on this - I feel I've done due diligence with following contributor instructions etc, but please let me know if I'm missing something, or where to look for clues.

[dyfer]

I was trying to see if the build would pass after rebasing, but it seems that the PR needs the CI-long-timeout label.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[dyfer]

@SMillerDev I'd be grateful for any further guidance how I can fix this PR. As I said before, I don't see how my change results in the CI failure, but I'd be happy to investigate if you can provide any pointers. I have rebased this PR to see if that fixes the issue, but the CI did not complete due to label CI-long-timeout not being set.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[dyfer]

I've force-pushed an update to resolve conflict with the current master branch.

[dyfer]

FWIW, a recently merged libsndfile PR seemed to have the same CI failure as the failing Linux run in this PR (aside from Qt-related failures). I'd like to reiterate that I don't think that changes in this PR contributed to the CI failure on Linux. I'd appreciate a re-review of this PR.

[chenrui333]

Sorry about the delay, doing another run now.

previous build run, https://github.com/Homebrew/homebrew-core/actions/runs/3173511664/jobs/5249901340

[chenrui333]

elf installation on 11 is due to networking issue

spotifyd installation issue on linux

  ==> Pouring spotifyd--0.3.2.x86_64_linux.bottle.2.tar.gz
  Error: cannot normalize PT_NOTE segment: non-contiguous SHT_NOTE sections

Gonna do a rerun for failed jobs

[chenrui333]

actually I dont think it worth it. Merging the PR.

[BrewTestBot]

:shipit: @chenrui333 has triggered a merge.

[chenrui333]

Thanks @dyfer!