fuego-firestore 0.31.1 (new formula)

[bboles]

• [x] Have you followed the guidelines for contributing?
• [x] Have you ensured that your commits follow the commit style guide?
• [x] Have you checked that there aren't other open pull requests for the same formula update/change?
• [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[bboles]

FYI @sgarciac

[bboles]

Is this error from the linter applicable?:

Formula/fuego-firestore.rb:15:72: W: Useless assignment to variable - result.
      collections_output = shell_output("#{bin}/fuego collections 2>&1", result = 80)
                                                                         ^^^^^^
  
  6104 files inspected, 1 offense detected
  Error: Useless assignment to variable - `result`.

We don't exit with 0 but with 80 instead so we need to capture that. Assertion documentation for reference.

[bboles]

@chenrui333 based on my previous comment, anything else I can do to move this PR forward?

[SMillerDev]

That doc doesn't say you need to assign it to a variable though. It just documents how it's defined in brew.

[bboles]

Is there anything else I need to do to move this PR forward?

[bboles]

@chenrui333 would you mind giving my PR another review?

[bboles]

Hi @chenrui333 and @SMillerDev, is there anything else I need to do with this PR?

[bboles]

Hi @chenrui333 and @SMillerDev, just checking in to see what needs to happen to get this PR merged. Thank you!

[bboles]

Hi @alebcay, can we get this PR merged now that all checks are good?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[sgarciac]

bump.

[BrewTestBot]

:shipit: @chenrui333 has triggered a merge.