homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

Published 20 hours ago • verified publisher icon Homebrew

cql-proxy 0.1.1 (new formula)

Open aar0np opened this issue 3 years ago • 8 comments

cql-proxy is a lightweight sidecar to allow easier connectivity to Cassandra, AstraDB and compatible databases.

  • [x] Have you followed the guidelines for contributing?
  • [x] Have you ensured that your commits follow the commit style guide?
  • [x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [x] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [x] Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

aar0np avatar May 23 '22 18:05 aar0np

ping @aar0np

chenrui333 avatar Jun 07 '22 15:06 chenrui333

Sorry @chenrui333 , been a little busy. I'm back on this today, and I'll get that test reworked.

aar0np avatar Jun 08 '22 13:06 aar0np

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Jun 30 '22 00:06 github-actions[bot]

ping @chenrui333

aar0np avatar Jun 30 '22 02:06 aar0np

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Aug 11 '22 00:08 github-actions[bot]

ping @chenrui333 @carlocab

It's been a while since I've submitted this. Please help me get this merged.

Thank you

aar0np avatar Aug 11 '22 13:08 aar0np

Hi @aar0np, just added some feedback on the test block issue. The exec difference mentioned in the earlier thread should be addressed because as it currently stands, the latter part of the test is not being executed at all (skipped due to use of exec).

alebcay avatar Aug 11 '22 16:08 alebcay

Thank you, @alebcay ! I'll give it another look and amend the PR when I get it working.

aar0np avatar Aug 11 '22 16:08 aar0np

Ok, I think I have this in a good spot. Please review and let me know!

aar0np avatar Aug 11 '22 19:08 aar0np

:shipit: @chenrui333 has triggered a merge.

BrewTestBot avatar Aug 13 '22 04:08 BrewTestBot

@aar0np, thanks for your contribution to Homebrew! :tada: 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

chenrui333 avatar Aug 13 '22 04:08 chenrui333

@aar0np, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

No problem! Thanks for being patient with me.

QQ: I noticed the PR was "closed" but not "merged." Is that anything to be concerned about?

aar0np avatar Aug 13 '22 16:08 aar0np

QQ: I noticed the PR was "closed" but not "merged." Is that anything to be concerned about?

Not at all. Most PRs are merged this way. See https://github.com/Homebrew/homebrew-core/commit/559d9698f62aa955fed54e43f1b8f876fb4221af.

carlocab avatar Aug 13 '22 16:08 carlocab