homebrew-core icon indicating copy to clipboard operation
homebrew-core copied to clipboard

nut 2.8.0

Open chenrui333 opened this issue 3 years ago • 6 comments

Created with brew bump-formula-pr.

chenrui333 avatar May 07 '22 17:05 chenrui333

  dummy-ups.c:238:24: error: no member named 'st_mtim' in 'struct stat'
                                          if (datafile_stat.st_mtim.tv_sec != fs.st_mtim.tv_sec) {
                                              ~~~~~~~~~~~~~ ^
  dummy-ups.c:238:45: error: no member named 'st_mtim' in 'struct stat'
                                          if (datafile_stat.st_mtim.tv_sec != fs.st_mtim.tv_sec) {
                                                                              ~~ ^
  2 errors generated.

chenrui333 avatar May 07 '22 17:05 chenrui333

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions[bot] avatar May 09 '22 19:05 github-actions[bot]

/usr/bin/install: cannot create regular file '/usr/lib/tmpfiles.d/nut-common.tmpfiles': Permission denied Makefile:621: recipe for target 'install-systemdtmpfilesDATA' failed

chenrui333 avatar Jul 04 '22 16:07 chenrui333

cc @Homebrew/linux

chenrui333 avatar Jul 08 '22 23:07 chenrui333

There is a probably a flag that needs to be set to tell this where to install the tmpfiles.

danielnachun avatar Jul 09 '22 04:07 danielnachun

time to have a new try after updating ubuntu runtime from v16 to v22

chenrui333 avatar Sep 22 '22 16:09 chenrui333

Still failing, reported it upstream: https://github.com/networkupstools/nut/issues/1668

At this point, I'd suggest closing the PR.

fxcoudert avatar Oct 03 '22 16:10 fxcoudert

I think I have a possible solution to this - we need to use the --with-systemdtmpfilesdir argument to tell nut to put those files elsewhere. I'm not sure what the right directory for that is.

danielnachun avatar Oct 03 '22 18:10 danielnachun

I'd say pkgshare

fxcoudert avatar Oct 03 '22 18:10 fxcoudert

The fix I pushed worked on Linux. We're still seeing a livecheck failure - @chenrui333 perhaps we should switch to using the upstream GitHub repo?

danielnachun avatar Oct 03 '22 22:10 danielnachun

Also looks like this was using the value from our systemd where one of files has prefix=/usr. Though, the path itself wouldn't have been writable if using systemd's prefix:

$ pkg-config --variable=tmpfilesdir systemd
/usr/lib/tmpfiles.d

$ grep prefix .linuxbrew/opt/systemd/share/pkgconfig/systemd.pc
# Names with prefixes are preferred, and the run-together names should be
prefix=/usr
root_prefix=/home/linuxbrew/.linuxbrew/Cellar/systemd/251_1
rootprefix=${root_prefix}
systemd_util_dir=${root_prefix}/lib/systemd
systemd_system_unit_dir=${rootprefix}/lib/systemd/system
systemd_system_preset_dir=${rootprefix}/lib/systemd/system-preset
systemd_user_unit_dir=${prefix}/lib/systemd/user
systemd_user_preset_dir=${prefix}/lib/systemd/user-preset
systemd_system_generator_dir=${root_prefix}/lib/systemd/system-generators
systemd_user_generator_dir=${prefix}/lib/systemd/user-generators
systemd_sleep_dir=${root_prefix}/lib/systemd/system-sleep
systemd_shutdown_dir=${root_prefix}/lib/systemd/system-shutdown
tmpfiles_dir=${prefix}/lib/tmpfiles.d
sysusers_dir=${rootprefix}/lib/sysusers.d
sysctl_dir=${rootprefix}/lib/sysctl.d
binfmt_dir=${rootprefix}/lib/binfmt.d
modules_load_dir=${rootprefix}/lib/modules-load.d
catalog_dir=${prefix}/lib/systemd/catalog

cho-m avatar Oct 05 '22 06:10 cho-m

The fix I pushed worked on Linux. We're still seeing a livecheck failure - @chenrui333 perhaps we should switch to using the upstream GitHub repo?

yeah, I think so. The homepage only sort of showing the latest release as NEWS, but maybe we can do a followup PR on this, cc @samford

chenrui333 avatar Oct 08 '22 16:10 chenrui333

I think we are good to go?

chenrui333 avatar Oct 08 '22 16:10 chenrui333

The fix I pushed worked on Linux. We're still seeing a livecheck failure - @chenrui333 perhaps we should switch to using the upstream GitHub repo?

yeah, I think so. The homepage only sort of showing the latest release as NEWS, but maybe we can do a followup PR on this

The tarball from the stable releases on GitHub are the same as the one from the first-party website (i.e., same SHA256), so I agree that there's something to be said for switching the stable source. Identifying stable versions from the first-party website requires digging through the source directories, whereas we can simply use GithubLatest if we switch to the GitHub tarball.

Edit: A follow-up PR to fix the livecheck block can be found at #112650.

samford avatar Oct 08 '22 17:10 samford

:robot: A scheduled task has triggered a merge.

BrewTestBot avatar Oct 08 '22 18:10 BrewTestBot