homebrew-cask icon indicating copy to clipboard operation
homebrew-cask copied to clipboard

sideserver 1.0.6 (new cask)

Open def324 opened this issue 1 year ago • 2 comments

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

  • [x] The submission is for a stable version or documented exception.
  • [x] brew audit --cask --online <cask> is error-free.
    • With the exception of the following, with reasoning below:
      • Upstream defined :mojave as the minimum OS version and the cask defined :catalina
      • GitHub fork (not canonical repository)
        • SideStore is a fork of AltStore (there is already a cask for it called altserver), however with significant improvements. Therefore it is valuable to have a separate cask for it.
  • [x] brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

  • [x] Named the cask according to the token reference.
  • [x] Checked the cask was not already refused.
  • [x] Checked the cask is submitted to the correct repo.
  • [x] brew audit --cask --new <cask> worked successfully.
    • Exceptions listed above.
  • [x] HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • [x] brew uninstall --cask <cask> worked successfully.

def324 avatar Feb 03 '24 06:02 def324

The tests failed due to the following reasons, as also described in the original pull request.

  • Upstream defined :mojave as the minimum OS version and the cask defined :catalina
  • GitHub fork (not canonical repository)
    • SideStore is a fork of AltStore (there is already a cask for it called altserver), however with significant improvements. Therefore it is valuable to have a separate cask for it.

I would appreciate any feedback on how to best resolve these and I'll be happy to make the needed changes.

def324 avatar Feb 03 '24 06:02 def324

I've asked upstream to unfork. I'll finish the cask once this has been done. Thanks for all your suggestions, I really appreciate them.

def324 avatar Feb 16 '24 19:02 def324

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Mar 09 '24 00:03 github-actions[bot]