homebrew-cask icon indicating copy to clipboard operation
homebrew-cask copied to clipboard

Published 20 hours ago • verified publisher icon Homebrew

Use `arch` and `on_arch_conditional` DSLs

Open Rylan12 opened this issue 3 years ago • 2 comments

This PR modifies the remaining casks to use the new arch and on_arch_conditional DSLs instead of arch = Hardware::CPU.intel? ? "intel" : "arm". The casks in this PR are the ones that needed some sort of manual intervention and brew style --fix wasn't able to handle completely.

As with the large PR, I've verified that everything is working as expected by running brew info --json=v2 --all before and after the changes in this PR (I check on both Intel and ARM). There were no differences, indicating that all URLs remain the same after these changes.

Rylan12 avatar Aug 10 '22 22:08 Rylan12

CI failure is not due to this change, but because openshift-client needs a version bump. Should I do that in this PR or ci-syntax-only it and open a follow-up to bump?

Rylan12 avatar Aug 10 '22 23:08 Rylan12

Done in https://github.com/Homebrew/homebrew-cask/pull/129530

SMillerDev avatar Aug 11 '22 08:08 SMillerDev