homebrew-cask icon indicating copy to clipboard operation
homebrew-cask copied to clipboard

Upgrade DeSmuME.app to 0.9.13

Open murs313 opened this issue 2 years ago • 5 comments

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • [ ] Named the cask according to the token reference.
  • [ ] Checked the cask was not already refused.
  • [ ] Checked the cask is submitted to the correct repo.
  • [ ] brew audit --new-cask <cask> worked successfully.
  • [ ] brew install --cask <cask> worked successfully.
  • [ ] brew uninstall --cask <cask> worked successfully.

murs313 avatar Aug 03 '22 14:08 murs313

CI failed with the following error:

Version '0.9.13' differs from '0_9_13' retrieved by livecheck.

Is the applied livecheck strategy github_latest? If so, I think it's because of the underscore in the tag name... https://github.com/TASEmulators/desmume/releases/latest

I don't have an idea of the appropriate livecheck. Can you help me?

murs313 avatar Aug 03 '22 15:08 murs313

If you run brew lc --cask --debug desmume it will tell you what strategy is being used. With the new URL you've provided, it's using the Git strategy.

I've added some suggestions to correctly grab the latest version and handle the . to _ issue. Take a look and let me know if it's helpful. I verified this works locally.

p-linnane avatar Aug 03 '22 18:08 p-linnane

Thank you, @p-linnane ! I confirmed the strategy being used.

Where can I see the suggestions you added...? Sorry if I have misunderstood due to my English ability. TT

murs313 avatar Aug 04 '22 08:08 murs313

They're right above my last comment. Or if you go to the 'Files changed' tab you can see them as well. You can merge my suggestions in or use them as a reference to implement them yourself.

p-linnane avatar Aug 04 '22 15:08 p-linnane

Thanks, @p-linnane ! I know about the "suggested change" feature on github, but it doesn't appear to be there. Maybe you have "Start a review" and not "Finish your review"? Is there a "Pending" sign near the commit? Such as this: スクリーンショット 2022-08-05 16 34 08

murs313 avatar Aug 05 '22 07:08 murs313

Thank you @murs313.

miccal avatar Aug 15 '22 04:08 miccal