gsoc icon indicating copy to clipboard operation
gsoc copied to clipboard

Deduplicate and cleanup GitHub Actions

Open MikeMcQuaid opened this issue 2 years ago • 12 comments

Homebrew makes extensive use of GitHub Actions. Some of our workflows are pretty similar to each other and could be reused within the Homebrew organisation and community.

See more details in https://github.com/Homebrew/brew/issues/11101

MikeMcQuaid avatar Feb 01 '22 14:02 MikeMcQuaid

I think this'd make a good 175 hour project.

mistydemeo avatar Feb 14 '22 01:02 mistydemeo

Hello, my name is Fikar and I'm interested in this project. Based on the description provided in README, I'll try to read the issues and homebrew docs first. I would find it very helpful if you could recommend to me pages to read about homebrew (like the flow of development or homebrew components).

mohzulfikar avatar Mar 13 '22 17:03 mohzulfikar

All homebrew documentation is available through docs.brew.sh.

SMillerDev avatar Mar 13 '22 17:03 SMillerDev

If you have specific questions, feel free to ask and we'll be happy to provide whatever information you need.

mistydemeo avatar Mar 13 '22 18:03 mistydemeo

Sure thank you. So as I read and explore through the brew and core repository, seems like there is already composite action implemented in part of ci (e.g. Homebrew/actions/git-user-config@master to config git user in ci).

I see that there's several repeatable action for using brew style on several CI. Is this a good start point for contributing to this project? Any feedback will be helpful.

Thank you.

mohzulfikar avatar Apr 15 '22 06:04 mohzulfikar

So as I read and explore through the brew and core repository, seems like there is already composite action implemented in part of ci (e.g. Homebrew/actions/git-user-config@master to config git user in ci).

Doing more stuff like this would be great!

I see that there's several repeatable action for using brew style on several CI. Is this a good start point for contributing to this project? Any feedback will be helpful.

That'd be great. Can you elaborate on what you're thinking here?

MikeMcQuaid avatar Apr 15 '22 14:04 MikeMcQuaid

git-user-config action is not a composite action though.

dawidd6 avatar Apr 15 '22 15:04 dawidd6

Thank you for the answer, I would try to submit my PR for the gsoc requirement first and compiling the documents. From that documents we might have several thing to discuss.

mohzulfikar avatar Apr 16 '22 07:04 mohzulfikar

git-user-config action is not a composite action though.

Well, I think I would have to read the GitHub docs again thank you for pointing it out!

mohzulfikar avatar Apr 16 '22 07:04 mohzulfikar

Hello there, sorry for keep you waiting. I have submitted the proposal for this project. Please let me know if there's any question. Thank you.

mohzulfikar avatar Apr 18 '22 19:04 mohzulfikar

Following up the discussion on Homebrew/brew#11101,

I'm planning to change some CI in homebrew project. The First one that I want to be grouped with composite action is this code on homebrew-core.

      - name: Failures summary for brew test-bot --only-formulae
        if: always()
        run: |
          touch bottles/steps_output.txt
          cat bottles/steps_output.txt
          rm bottles/steps_output.txt
      - name: Output brew bottle result
        if: always()
        run: |
          cat bottles/bottle_output.txt
          rm bottles/bottle_output.txt

The link to the action workflow is here:

  1. dispatch-rebottle
  2. dispatch-build-bottle

Any additional suggestions or comments? Thank you

mohzulfikar avatar Jun 29 '22 12:06 mohzulfikar

@mohzulfikar That makes sense to me! A PR will be easier to review and comment on.

MikeMcQuaid avatar Jun 29 '22 12:06 MikeMcQuaid