Add appimage support for linux
- [x] Have you followed the guidelines in our Contributing document?
- [ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? Here's an example.
- [x] Have you successfully run
brew stylewith your changes locally? - [x] Have you successfully run
brew typecheckwith your changes locally? - [ ] Have you successfully run
brew testswith your changes locally?
This adds support for the first linux-only cask stanza: app_image.
We should probably add CI for Linux casks, but haven't been able to get that working yet.
We should probably add CI for Linux casks, but haven't been able to get that working yet.
Need CI before this PR is merged.
Where are the app images installed and is that an expected/sensible location?
Maybe we should reuse app for this on Linux (or is that too confusing)?
Maybe we should reuse app for this on Linux
I considered it, but deemed it too confusing. Especially with it not working on macOS.
Where are the app images installed and is that an expected/sensible location?
In ~/Applications, their docs recommend it.
https://docs.appimage.org/user-guide/faq.html#question-where-do-i-store-my-appimages
@SMillerDev sounds good 👍🏻
I'm also considering adding a desktop file for these so the various Linux systems can pick it up easily.
Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
This is waiting for the following pieces:
- [ ] Adding integration tests to testbot so I don't break it again
- [ ] Add cask change detection to testbot
- [ ] Adding Linux CI to homebrew/cask
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Not stale, but it is waiting for Linux CI for casks, and that's not going as fast as I'd like. So help would be much appreciated.
Okay, now that Linux CI for casks is merged I'm planning to:
- [ ] make a PR that stops requiring
--caskin Linux - [ ] Prepare this PR for review
I guess this is an implementation of https://github.com/Homebrew/brew/issues/15808
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Planning to finish this after the 22nd when I'm back from holiday.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.