brew icon indicating copy to clipboard operation
brew copied to clipboard

Fix type comparison for gh

Open pmartindev opened this issue 1 year ago • 1 comments

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew typecheck with your changes locally?
  • [ ] Have you successfully run brew tests with your changes locally?

Casting gh_version to a string prior to comparison to resolve the mismatched type error. CleanShot 2024-08-12 at 15 37 31

pmartindev avatar Aug 12 '24 20:08 pmartindev

Thanks @woodruffw! I'm happy to add the test with your guidance, or you can feel free to add it 😃 Are you looking for the same test you implemented in #17926 , or an additional test against the version?

pmartindev avatar Aug 13 '24 17:08 pmartindev

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 04 '24 00:09 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 26 '24 00:09 github-actions[bot]