brew icon indicating copy to clipboard operation
brew copied to clipboard

Add note about ghcr.io for HOMEBREW_DOCKER_REGISTRY_TOKEN

Open azatoth opened this issue 1 year ago • 3 comments

It's not clear that when using HOMEBREW_DOCKER_REGISTRY_TOKEN directly against ghcr.io that you should use your PAT base64-encoded as the bearer token.

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew typecheck with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

azatoth avatar Mar 02 '24 17:03 azatoth

(Prior discussion for context: https://github.com/orgs/Homebrew/discussions/5171)

Bo98 avatar Mar 05 '24 04:03 Bo98

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Apr 09 '24 00:04 github-actions[bot]

Would like to see comments addressed or further discussion, thanks!

I might have misunderstood you, but I thought I had addressed your comments, and I don't know what more I can say to further the issue.

azatoth avatar Apr 09 '24 12:04 azatoth

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Aug 16 '24 00:08 github-actions[bot]