brew icon indicating copy to clipboard operation
brew copied to clipboard

service: use default.target on Linux

Open SMillerDev opened this issue 3 years ago • 2 comments

  • [x] Have you followed the guidelines in our Contributing document?
  • [ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [ ] Have you successfully run brew style with your changes locally?
  • [ ] Have you successfully run brew typecheck with your changes locally?
  • [ ] Have you successfully run brew tests with your changes locally?

Should fix https://github.com/Homebrew/homebrew-services/issues/508

SMillerDev avatar Sep 21 '22 13:09 SMillerDev

Review period will end on 2022-09-22 at 13:21:19 UTC.

BrewTestBot avatar Sep 21 '22 13:09 BrewTestBot

Review period ended.

BrewTestBot avatar Sep 22 '22 15:09 BrewTestBot

I allowed myself to fix the tests to get this PR merged faster as the issue just hit me.

dawidd6 avatar Oct 07 '22 13:10 dawidd6

Tested locally, works alright but needs to first stop the service, reinstall a formula and start the service back up.

dawidd6 avatar Oct 07 '22 13:10 dawidd6

Those test failures seem to be unrelated?

dawidd6 avatar Oct 07 '22 15:10 dawidd6

I can confirm that this works perfectly fine for me, great job and many thanks! :pinata:

enernico avatar Oct 11 '22 08:10 enernico