brew icon indicating copy to clipboard operation
brew copied to clipboard

shims: make xcrun look at superenv bin first

Open Bo98 opened this issue 2 years ago • 5 comments

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [ ] Have you successfully run brew typecheck with your changes locally?
  • [ ] Have you successfully run brew tests with your changes locally?

This closes a superenv bypass where build systems using xcrun clang or xcrun --find clang returned the path directly to Xcode's clang. This meant formulae like qt@5 has never used our superenv clang.

This does require a bit of arg parsing in our xcrun shim which is unfortunate (need to watch for changes to system xcrun - though the tool has been stable for a while), but necessary to replicate the behaviour of system xcrun.

Bo98 avatar Dec 02 '21 16:12 Bo98

Review period will end on 2021-12-03 at 16:34:50 UTC.

BrewTestBot avatar Dec 02 '21 16:12 BrewTestBot

Review period ended.

BrewTestBot avatar Dec 03 '21 21:12 BrewTestBot

Related to Qt and superenv: https://code.qt.io/cgit/pyside/pyside-setup.git/tree/sources/shiboken6/ApiExtractor/clangparser/compilersupport.cpp#n118

carlocab avatar Dec 06 '21 17:12 carlocab

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Dec 28 '21 00:12 github-actions[bot]

This fixes a bug that confuses Ruby's build into trying to install its headers into the SDK. See Homebrew/homebrew-core#92024.

carlocab avatar Jan 15 '22 10:01 carlocab

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Oct 19 '22 00:10 github-actions[bot]