HoloClean-Legacy-deprecated icon indicating copy to clipboard operation
HoloClean-Legacy-deprecated copied to clipboard

Removed setup.py

Open j48zheng opened this issue 6 years ago • 1 comments

Removed the setup.py in the root directory. I'm not sure how it works and there are no instructions on the README. Either deleting it with this PR or someone who knows what it does, tests it and adds to the README.

j48zheng avatar Jul 07 '18 15:07 j48zheng

Not sure you want to do this. You use setup.py to install a local copy of holoclean, the equivalent of pip install holoclean. Everytime you make a dev change you can run a quick python setup.py install to update build artifacts in your env. This means you also don’t need a relative path to the holoclean directory every time you need to use it. It’s also needed to upload anything to PyPi (which imo should be done). I use it in my dev workflow.

ankur-gos avatar Jul 07 '18 16:07 ankur-gos