nitro-docker icon indicating copy to clipboard operation
nitro-docker copied to clipboard

Add atom cms and atom hk

Open dev-luizf opened this issue 1 year ago • 7 comments

This PR adds atom cms and hk to the project. It was based on @alanlomeli fork here, with some changes and fixes by me.

TO DO:

  • [x] - Update readme with instructions on when run the new just commands

dev-luizf avatar Jan 15 '24 00:01 dev-luizf

Hi @dev-luizf !

This MR is ready to review ? Or I need to wait the last TODO ?

(And thank you @alanlomeli)

Pi-Bouf avatar Jan 15 '24 08:01 Pi-Bouf

Hi @dev-luizf !

This MR is ready to review ? Or I need to wait the last TODO ?

(And thank you @alanlomeli)

I think it would be better wait the last todo and one config about atom hk that I forgot. But the other PR is ready to review.

dev-luizf avatar Jan 15 '24 10:01 dev-luizf

It is done @Pi-Bouf, you can review.

I'm not sure if atom submodules were added, because when a ran just install in a clean instalation they were not cloned, can you check it?

dev-luizf avatar Jan 15 '24 23:01 dev-luizf

Any updates on this? @Pi-Bouf

dev-luizf avatar Jan 28 '24 13:01 dev-luizf

Sorry @dev-luizf , I will take a look really soon !

Pi-Bouf avatar Jan 28 '24 14:01 Pi-Bouf

OK I tried, i've got some request:

  • please rebase with main
  • add your submodule folder, instead of that we can't have atom :(

@dev-luizf

About the second point, you mean create atom and atom-hk folders?

I don't know much about git submodules

dev-luizf avatar Feb 05 '24 17:02 dev-luizf

OK I tried, i've got some request:

  • please rebase with main
  • add your submodule folder, instead of that we can't have atom :(

@dev-luizf

About the second point, you mean create atom and atom-hk folders?

I don't know much about git submodules

Yes, when you setup a submodule you got two things: an entry inside the .gitmodules and a folder referencing the cloned module / the target and which branch to use

Pi-Bouf avatar Feb 05 '24 17:02 Pi-Bouf