Ravi van Rooijen

/bloodmoon force

As I already said in #656, keeping the (fixed) typings in DT would probably be the best solution *for now*. I still prefer integrating the typings into the module eventually,...

I just noticed that although the readme says that [a store *must* be an `EventEmitter`](https://github.com/expressjs/session#session-store-implementation) there's no mention of *why* they have to be and how it's actually used. I've...

Turns out declaration merging doesn't work properly with these definitions, currently investigating.

I have addressed your concerns, including a crude concept of additional documentation in the readme. What do you think about my suggestion to remove the optional modifier on `Request.session` and...

> I don't know what this means, can you elaborate if you need an answer from me? Typescript employs strict null/undefined checking, which basically means that the compiler screams at...

I found another possible mistake in the typings which boils down to the following: do the functions on the `Store` class expect a full-blown `Session` (including `id`, `cookie`, `regenerate`, etc.)...

I have decided to drop the optional modifier on `session`/`sessionID`, mainly because in 99% of the cases it's completely useless. It's just unnecessarily inconvenient, and it's safe to assume someone...

> Have a passing CI to merge Don't ask me how but I never noticed that the tests are failing. No idea how that can happen by the addition of...

> So the safe to land in 1.x is, overall, my main concern. Is there any way to gather what would happen to an existing app? Do you know a...