Ravi van Rooijen

Results 138 comments of Ravi van Rooijen

Interesting, that function must've been added in a more recent version. I'd still argue that a "convenience" function in ts-morph would be nice as well, but that's @dsherret's call.

Sounds good! I'll hopefully get to it later today. Edit: I found `ts.getLineAndCharacterOfPosition` as well, so `StringUtils.getLineNumberAtPos` can be replaced too

> Or just import the `lib.dom` types, and re-export the ones we are interested about. This wouldn't work because merely touching `lib.dom.d.ts` pollutes the global scope. However, as a temporary...

Wow this an old issue...

Whoops I completely forgot about the linter. I fixed *almost* all errors (most of them were the indentation), with just 2 remaining. These relate to the evil global variables, and...

Because there is no reason for using arrow functions here, it just hurts readability. Having the actual `function` keyword makes it very clear where the functions are instead of hiding...

As I said earlier: > ESLint wants me to declare these variables before they are used. Fair game, it would be really stupid to bury globals like this. ESLint also...

Probably a (disrespectful) duplicate of #339.

Purely out of curiosity, what kind of property would have a '?' in its name? As for checking if a property name should be quoted: the rules for a valid...