AtlasLootClassic icon indicating copy to clipboard operation
AtlasLootClassic copied to clipboard

lua error 10/10

Open ibwukster opened this issue 1 year ago • 21 comments

AtlasLoot version current as of 10/10/23

Lua error Message: Interface/AddOns/AtlasLootClassic/Data/Companion.lua:674: table index is nil Time: Tue Oct 10 18:38:36 2023 Count: 1 Stack: Interface/AddOns/AtlasLootClassic/Data/Companion.lua:674: table index is nil [string "@Interface/AddOns/AtlasLootClassic/Data/Companion.lua"]:674: in function <Interface/AddOns/AtlasLootClassic/Data/Companion.lua:669> [string "@Interface/AddOns/AtlasLootClassic/Data/Companion.lua"]:682: in function <Interface/AddOns/AtlasLootClassic/Data/Companion.lua:677> [string "@Interface/AddOns/AtlasLootClassic/Data/Companion.lua"]:689: in function `func' [string "@Interface/AddOns/AtlasLootClassic/AtlasLoot.lua"]:42: in function <Interface/AddOns/AtlasLootClassic/AtlasLoot.lua:34>

Locals: typ = "MOUNT" (for index) = 1 (for limit) = 20 (for step) = 1 i = 1 creatureID = nil (*temporary) =

{ 24480 = true 194870 = true 28513 = true } (*temporary) = 1 (*temporary) = "table index is nil" COLLECTED_COMPANIONS =
{ 24480 = true 194870 = true 28513 = true }

ibwukster avatar Oct 10 '23 22:10 ibwukster

PR #398 fixes this issue

jazminite avatar Oct 11 '23 02:10 jazminite

how do you download this update? I am struggling to find it in here lol

vgullotta8 avatar Oct 11 '23 14:10 vgullotta8

I have created a release here which has a direct download link: Direct Download Link

Anyalah avatar Oct 11 '23 14:10 Anyalah

Awesome, thank you, and thank you for the work on this awesome addon!

vgullotta8 avatar Oct 11 '23 14:10 vgullotta8

Yes, thank you for the direct link also, couldn't figure out why it was still broke.

Devanna909 avatar Oct 11 '23 14:10 Devanna909

I have created a release here which has a direct download link: Direct Download Link

Only issue I'm seeing is every time you hit a load screen, you get the following chat message "AtlasLoot-Def: Player "X-Server" sends version '3010003'! Anyway to fix this? Cause once you join a raid, you'll see that constantly with load screens or reloads.

ZhandPally avatar Oct 11 '23 15:10 ZhandPally

Only issue I'm seeing is every time you hit a load screen, you get the following chat message "AtlasLoot-Def: Player "X-Server" sends version '3010003'! Anyway to fix this? Cause once you join a raid, you'll see that constantly with load screens or reloads.

Comment out this line in AtlasLoot.lua (line 182 in this pre-release version): AtlasLoot:DevPrint(format("Player '|cff00FAF6%s|r' sends version '|cff00FF96%d|r'!", sender, v))

kazso avatar Oct 11 '23 18:10 kazso

Sorry, cancel that, I am an idiot. XD

vgullotta8 avatar Oct 11 '23 20:10 vgullotta8

Only issue I'm seeing is every time you hit a load screen, you get the following chat message "AtlasLoot-Def: Player "X-Server" sends version '3010003'! Anyway to fix this? Cause once you join a raid, you'll see that constantly with load screens or reloads.

Comment out this line in AtlasLoot.lua (line 182 in this pre-release version): AtlasLoot:DevPrint(format("Player '|cff00FAF6%s|r' sends version '|cff00FF96%d|r'!", sender, v))

Awesome, thank you!

ZhandPally avatar Oct 11 '23 23:10 ZhandPally

@Anyalah

I have created a release here which has a direct download link: Direct Download Link

Thanks, but why did you delete all localizations?

Iowerth avatar Oct 12 '23 08:10 Iowerth

@Iowerth

@Anyalah

I have created a release here which has a direct download link: Direct Download Link

Thanks, but why did you delete all localizations?

No localization files were deleted in my commit, you can see the changes if you follow this link: https://github.com/Hoizame/AtlasLootClassic/pull/398/commits/0bc91eb6899bebbf3b99072b446c1b83778ddeb9 I may have added text that needs to be localised? Maybe you can be more specific if you're experiencing an issue.

Anyalah avatar Oct 12 '23 11:10 Anyalah

@Anyalah

No localization files were deleted in my commit, you can see the changes if you follow this link: 0bc91eb I may have added text that needs to be localised? Maybe you can be more specific if you're experiencing an issue.

Open your archive please and you'll see that all localization files (in *\Locales folders) have size 300 bytes - they are almost empty.

Iowerth avatar Oct 12 '23 11:10 Iowerth

When does Curseforge get updated?

Syllinger avatar Oct 12 '23 12:10 Syllinger

@Syllinger As soon as it possible.

Iowerth avatar Oct 12 '23 13:10 Iowerth

@Anyalah

No localization files were deleted in my commit, you can see the changes if you follow this link: 0bc91eb I may have added text that needs to be localised? Maybe you can be more specific if you're experiencing an issue.

Open your archive please and you'll see that all localization files (in *\Locales folders) have size 300 bytes - they are almost empty.

Okay I see now, there is a comment in each file saying these are translated on curseforge, it may be that it is populated when the addon is uploaded to curse? if you look at the current version on github its the same as in my commit with all those files being mostly empty. I am sure they will be in the proper release when Hoizame is back to do that.

Anyalah avatar Oct 12 '23 21:10 Anyalah

After using the direct download link, Where would I extract all files to?

Gaspasser5 avatar Oct 13 '23 17:10 Gaspasser5

After using the direct download link, Where would I extract all files to?

World of Warcraft/_classic/Interface/AddOns

Pocokk avatar Oct 14 '23 08:10 Pocokk

Still not fixed?

DieQuelle avatar Oct 16 '23 21:10 DieQuelle

@DieQuelle do you see update here or on Curseforge?

Iowerth avatar Oct 16 '23 21:10 Iowerth

any way to disable the chat spam with "AtlasLoot-Dev: Player 'playername' sends version '3010003' whenever someone joins/leaves the group?

image

Autobuz avatar Oct 20 '23 18:10 Autobuz

@Autobuz https://github.com/Hoizame/AtlasLootClassic/issues/399#issuecomment-1758306068

Iowerth avatar Oct 20 '23 19:10 Iowerth