hobo_vr
hobo_vr copied to clipboard
HoboVR-Labs
improvement/offline_windows_installer
installers/win: hobovr_installer.nsi: Removed Compilation step with Packaged Files.
Replaces the downloading and compiling of the repository with packaging of the compiled artifacts from the hobovr directory.
Future Expansion of the File wildcard into separate filenames and paths is recommended for cleaner installation options.
Signed-off-by: Nick Boyd [email protected]
Iirc, the file command copies the files into the resulting executable, and python is no longer really required for hobovr, so that's fine. However, isn't this replacing the online installer with an offline one rather than making a separate offline installer?
Indeed, currently there's no way to have an offline installer without either publishing the build artifacts somewhere or the earlier solution of ensuring a python environment and building the driver client-side.
Both Okawo and I have looked into downloading the build artifacts with personal access tokens and the like, but the GitHub API's scoping needs more investigation to find out if that's actually possible and how.
It's proven the starter of several help tickets and stackoverflow questions since the beginning as far as I can see, with the developer of the "Nightly" app writing a GitHub plugin to handle it out of the same frustration.
@SimLeek and @okawo80085 I'll rebase this on #8 tonight if that's alright with you chaps?
(this PR isn't yet ready for review, I need to rebase it off the updated branch and restructure the changes as another compilation target rather than overwriting the original)