Daniel Hlaváček
Daniel Hlaváček
Ping @florine2623, it's just a cosmetic change ;-)
Ping @PrestaShop/prestashop-sa
@kpodemski Ready
@M0rgan01 Yes maybe the default value is not possible for these columns - https://docs.google.com/spreadsheets/d/1DYQ4qdWN0YWSCl7RuibMn6aEdXte9Fd7RYz3iJ10hWA/edit?usp=sharing :-)
@WahbiPS Not completed
@gericfo This issue is NOT resolved! It has only been patched one time, but can break again, unless default values are implemented and data is properly casted on PHP side.
@jf-viguier Well, I see that your code is inside `if ($destinationFileType == 'png' || $destinationFileType == 'webp' || $destinationFileType == 'avif') {` It should be executed only if the source...
@jf-viguier There are two things I would like to challenge in the PR. I am 50/50 it's a good idea. - The png thumbnails are generated by our software for...
@jf-viguier I think you also need a check if the source file is png. Now you are running a check for all file types.
@jf-viguier You are now checking only the destination file type, but you should also check the source one.