brackets-ungit icon indicating copy to clipboard operation
brackets-ungit copied to clipboard

Can't uninstall without killing node

Open thany opened this issue 8 years ago • 3 comments

It's not my cup tea, this view of Git, so I uninstall the extension... Turns out that doesn't work: capture Nothing in the developer console is added. Just this error message.

This is on Brackets 1.4, Windows 7 x64, and (not sure if you need these) NPM 2.11.2 and Node 0.12.5.

thany avatar Aug 03 '15 09:08 thany

I also can't remove the extension manually even after closing Brackets. It's being used by something. Turns out that "something" is node itself. Apparently this extensions starts a server, but never stops it?... It should really stop the server on uninstalling. And perhaps on exiting Brackets, too.

/edit Yep, after killing Node, I could uninstall the extension. This probably still needs a fix in the extension too ;)

thany avatar Aug 03 '15 09:08 thany

To be honest, I have not tried to uninstall it yet as I was so busy getting the installation and startup to work. But I definitely agree that uninstalling should be supported. For now, one can either

  • uninstall the extension before opening it
  • uninstall the extension after killing node (or restarting the computer)
  • or after killing the Ungit process manually using Navigate > Kill Ungit

I have actually noticed the fact that node stays open after exiting Brackets, but during a quick search I have not found any Brackets.enExit hooks that I could use to terminate it.

Hirse avatar Aug 03 '15 09:08 Hirse

With v0.3.0 I am using child_process.fork to run Ungit which seems to at least exit when Brackets does, so you would be able to remove the folder manually.

Hirse avatar Aug 03 '15 09:08 Hirse