Thomas Casteleyn
Thomas Casteleyn
It looks like the Wavefront serializer already has some similar benchmark tests: https://github.com/influxdata/telegraf/blob/22b0a26b1d48292460f15acf946d96891bf0c726/plugins/serializers/wavefront/wavefront_test.go#L311-L330
Can I nominate plugins to be deprecated as well? - [inputs.leofs](https://github.com/influxdata/telegraf/tree/master/plugins/inputs/leofs) -> inputs.snmp Since this one is running the `snmpwalk` command and then parsing its output.
I'm not sure if the deprecation of `inputs.snmp.name` is a good thing, since the given alternative gives undesired results. https://github.com/influxdata/telegraf/blob/4321f8ae67a95f152aa5e83074e1e06f588811c1/plugins/inputs/snmp/snmp.go#L118
@sjwang90 I believe this should be also the case for the influx inputs, no? > Note that the two InfluxDB output plugins will remain. They are named influxdb and influxdb_v2,...
@sspaink You ticked off all deprecated plugins as being removed by #9609, but that isn't correct. The first one I checked isn't removed by that PR. Can you revisit that...
@sspaink? Edit: Nevermind, I updated the list.
I agree that `always` is the logical default. But as this is a new option and changes previous behaviour it is opted to default to `none` which is backward compatible....
Hi @dba-leshop are you willing to resolve the conflict and implement the suggested changes?
Great, you can mark the PR as ready to review when done.
Telegraf is indeed using the mentioned walk function, see the following parts: https://github.com/influxdata/telegraf/blob/30d981d3330986e6e181a61c045495b21bf2cdc5/plugins/inputs/snmp/snmp.go#L479 https://github.com/influxdata/telegraf/blob/30d981d3330986e6e181a61c045495b21bf2cdc5/internal/snmp/wrapper.go#L23-L30 https://github.com/gosnmp/gosnmp/blob/96366f3fa26cabbea05d3d854ad8577650246ffd/gosnmp.go#L567-L573 Using GetBulk implies you know on beforehand how many rows a table has, this is...