hipo-drf-exceptions icon indicating copy to clipboard operation
hipo-drf-exceptions copied to clipboard

Return list of strings instead of just string as dictionary values

Open efe opened this issue 4 years ago • 4 comments

efe avatar Jan 15 '21 11:01 efe

I think this update is backward-compatible, right?

yigitguler avatar Jan 18 '21 06:01 yigitguler

@yigitguler It isn't. Because some of the existing error messages (raising string) will behave differently. Should we bump the version to 0.2.1?

efe avatar Jan 18 '21 23:01 efe

But FE guys are can handle a list of errors, right? I think that's an important point. AFAIK they handle this, but it will be wise to make a version bump. Also what is preventing us to make this 1.0 ? We are already using this package for years in production :)

yigitguler avatar Jan 19 '21 07:01 yigitguler

I think this update is backward-compatible, right?

Technically this is a bug fix. FE should always expect list of errors for a key according to our documentation. But if some of the client handled a specific key as a string without telling us this might break something.

Version 1.0.0 sounds nice.

alicertel avatar Jan 19 '21 08:01 alicertel