Plugin-Metrics icon indicating copy to clipboard operation
Plugin-Metrics copied to clipboard

Plugin performed restricted action.

Open SilverCory opened this issue 10 years ago • 8 comments

I use the metrics in my plugin. And I was wondering if you could patch the Bungee plugin.

Bungeecord requests that instead of doing "new Thread()", you should use the Bungee scheduler.

Here is a stacktrace: 13:58:16 [WARNING] Plugin performed restricted action, please inform them to use proper API methods: Illegal thread group access java.security.AccessControlException: Plugin violation: Illegal thread group access at net.md_5.bungee.BungeeSecurityManager.checkRestricted(BungeeSecurityManager.java:39) at net.md_5.bungee.BungeeSecurityManager.checkAccess(BungeeSecurityManager.java:62) at java.lang.ThreadGroup.checkAccess(ThreadGroup.java:315) at java.lang.Thread.init(Thread.java:389) at java.lang.Thread.init(Thread.java:349) at java.lang.Thread.<init>(Thread.java:547) at eu.ac3_servers.dev.bvotifier.bungee.Metrics.start(Metrics.java:205) at eu.ac3_servers.dev.bvotifier.bungee.BVotifier.onEnable(BVotifier.java:69) at net.md_5.bungee.api.plugin.PluginManager.enablePlugins(PluginManager.java:207) at net.md_5.bungee.BungeeCord.start(BungeeCord.java:230) at net.md_5.bungee.Bootstrap.main(Bootstrap.java:65)

Link to the issue: https://bitbucket.org/acecheesecr14/bvotifier/issue/1/javasecurityaccesscontrolexception-plugin

SilverCory avatar Jul 21 '14 15:07 SilverCory

I would argue that the Bungee commit that implemented this is a dumb change and should be resolved by them for their idiotic waste of time.

turt2live avatar Jul 22 '14 03:07 turt2live

Okay, well it's there and I doubt it's going to be removed for one java class.

Other plugins adapt, if this plugin doesn't then it's a feature I can't use and mcstats will be useless to me!

SilverCory avatar Jul 22 '14 10:07 SilverCory

More info of the error can look on the https://github.com/Minecrell/ServerListPlus/issues/23 of the Bungee Plugin Metrics.

XxCoolGamesxX avatar Jul 22 '14 13:07 XxCoolGamesxX

@XxCoolGamesxX Well I use my own Plugin-Metrics implementation on BungeeCord so you can't use the fix of my issue for this one. The BungeeCord version here should be rewritten to use the BungeeCord scheduler (similar to the Bukkit version) instead of using threads directly. (Additionally #40 should be probably merged..)

For anyone interested, here is my own Plugin-Metrics implementation for BungeeCord: Minecrell/BungeeMetrics - it works a bit different to the versions here but won't warn about the thread creations.

stephan-gh avatar Jul 22 '14 18:07 stephan-gh

@Minecrell Thanks for the info :P It help the devs. :P

XxCoolGamesxX avatar Jul 22 '14 19:07 XxCoolGamesxX

@Minecrell brilliant. You beast ;P

SilverCory avatar Jul 23 '14 15:07 SilverCory

@acecheese You should keep it open until it is fixed anyway. ;)

stephan-gh avatar Jul 23 '14 16:07 stephan-gh

@minecrell Point!

SilverCory avatar Jul 28 '14 21:07 SilverCory