REVENGE.CSS icon indicating copy to clipboard operation
REVENGE.CSS copied to clipboard

Revert "Clarify the keyboard focus warning"

Open Heydon opened this issue 11 years ago • 4 comments

Reverts Heydon/REVENGE.CSS#7

Heydon avatar Aug 17 '14 09:08 Heydon

I think you're onto something here. However, ([tabindex]) should probably be concatenated with :not([tabindex="-1"]) ?

Heydon avatar Aug 17 '14 09:08 Heydon

Well, that would be a further improvement to my change. I wouldn't go as far as to revert it. Perhaps even have a separate rule:

button[tabindex="-1"], a[tabindex="-1"], .btn[tabindex="-1"], .button[tabindex="-1"], input[tabindex="-1"] {
}

P.S. Mention a developer to invite him to join a discussion. I got to know about this pull request by accident.

denis-sokolov avatar Aug 17 '14 10:08 denis-sokolov

@denis-sokolov like this? Yeah, sorry :-)

The trouble is tabindex="-1" is focusable programmatically. In some ARIA widgets, -1 on links or buttons is necessary for turning tabbing off before adding custom key controls like arrow keys (?)

Heydon avatar Aug 17 '14 12:08 Heydon

Well, then just leave it as it is. If somebody has explicitly chosen to add tabindex="-1", I don't think they need a warning about the element being unfocusable.

denis-sokolov avatar Aug 17 '14 14:08 denis-sokolov