Fixed issue #208 and added dev-runner script for selfhosting

[Braingix]

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

ÂOdah Bernard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jelveh]

Thank you for your contribution, Odah. Could you look into the CLA, it's needed before we can merge.

[Braingix]

Thank you for your contribution, Odah. Could you look into the CLA, it's needed before we can merge.

I have signed it.

[KernelDeimos]

The check isn't accepting it because the commit metadata differs from your GitHub account

[KernelDeimos]

This commit has a large amount of style changes. Is this your editor doing that? We'd like to keep style changes separate from bug fixes and features, so these will need to be removed or PR'd separately

[Braingix]

This commit has a large amount of style changes. Is this your editor doing that? We'd like to keep style changes separate from bug fixes and features, so these will need to be removed or PR'd separately

I think I have format on save turned on in my editor. Didn't check for that.

[Braingix]

The check isn't accepting it because the commit metadata differs from your GitHub account

So I have to make another PR?

[KernelDeimos]

The check isn't accepting it because the commit metadata differs from your GitHub account

So I have to make another PR?

For style changes I'm now thinking it's better to leave them out entirely. If we don't merge style changes it makes it more difficult for someone in the future to hide malicious changes in a massive "style PR" for example (like imagine something with 10x the changes of your PR, and then one line is changed somewhere; I think we don't want to set that precedent)

[Braingix]

The check isn't accepting it because the commit metadata differs from your GitHub account

So I have to make another PR?

For style changes I'm now thinking it's better to leave them out entirely. If we don't merge style changes it makes it more difficult for someone in the future to hide malicious changes in a massive "style PR" for example (like imagine something with 10x the changes of your PR, and then one line is changed somewhere; I think we don't want to set that precedent)

Got it.

[AtkinsSJ]

So I have to make another PR?

No, you should be able to add whichever email address you used for that commit, to your GitHub account. I think that will work.

And depending on how comfortable you are with git, you could:

1. Do a soft reset of the commit. (git reset --soft HEAD~1) This undoes the commit but keeps the file changes.
2. Discard the code-formatting changes.
3. Test it still works.
4. Create a new commit of the changes.
5. Force-push to update it here. (git push --force)

And in future I'd recommend using a separate branch for each PR, it makes things a bit easier to manage.

[KernelDeimos]

Closing as this is no longer active