retrowrite icon indicating copy to clipboard operation
retrowrite copied to clipboard

naming issue of global symbols

Open junxzm1990 opened this issue 5 years ago • 1 comments

Please consider changing the code at https://github.com/HexHive/retrowrite/blob/master/librw/loader.py#L196

The statement here will change the name of global symbols to "original_name_address". For instance, this will change "symbol1" (whose address is 0x90) to "symbol1_90" and keep the new name all the way to the assembly file. However, the other references to the symbol in the code or data will still use the original name. Re-assembling will complain "undefined symbol1_90".

junxzm1990 avatar Nov 14 '20 01:11 junxzm1990

Hi, thank you for taking the time to fill the issue. Could you provide us with a proof of concept binary that fails reassembly this way?

cyanpencil avatar Nov 18 '20 14:11 cyanpencil

No update received, therefore closing the issue

gannimo avatar Jul 13 '23 15:07 gannimo