magma icon indicating copy to clipboard operation
magma copied to clipboard

Upgrade Angora to most up-to-date. Changed some build script so Angora compiles

Open DataCorrupted opened this issue 3 years ago • 5 comments

Angora has migrated to LLVM11 and some bugs are fixed (See PR). Migrate Magma's Angora to the most updated version.

Signed-off-by: Peter Rong [email protected]

DataCorrupted avatar Jan 25 '22 01:01 DataCorrupted

Nice, thanks! I'll give it a spin today and see how it goes

adrianherrera avatar Feb 15 '22 21:02 adrianherrera

Can you please squash the commits and I can merge!

adrianherrera avatar Feb 21 '22 03:02 adrianherrera

Can you please squash the commits and I can merge!

Done

DataCorrupted avatar Feb 22 '22 05:02 DataCorrupted

Thanks for doing that!

Sorry, I just realized this PR was made against the v1.2 branch. Can you please make it against the dev branch and then I'll merge it. Sorry for the hassle!!! (I should add a CONTRIBUTING.md file that describes this)

adrianherrera avatar Feb 23 '22 23:02 adrianherrera

Thanks for doing that!

Sorry, I just realized this PR was made against the v1.2 branch. Can you please make it against the dev branch and then I'll merge it. Sorry for the hassle!!! (I should add a CONTRIBUTING.md file that describes this)

Done

DataCorrupted avatar Feb 23 '22 23:02 DataCorrupted

Hi @adrianherrera I don't think this is merged before you close it. Do you still want it?

(Sorry I forgot about this PR too)

DataCorrupted avatar Nov 08 '22 01:11 DataCorrupted