Kyle Benesch
Kyle Benesch
`_is_macho_file` performs a very simple magic number check so I wonder how easily this can be a false positive. https://github.com/matthew-brett/delocate/blob/b0c37814ae51a0f8ccef0678b4d61173f9a59919/delocate/tools.py#L173 Could do what you did and rely on the exceptions...
#229 has identified the problem as being caused by fat static libraries. I'm likely to continue any discussion over there.
This is a duplicate of #227, but this issue was better researched and written than the other one. This check was specifically to figure out compatibility of the whole wheel,...
It'd just need to replace `_get_macos_min_version` with a new implementation parsing `otool` instead of using `macholib`: https://github.com/matthew-brett/delocate/blob/b0c37814ae51a0f8ccef0678b4d61173f9a59919/delocate/delocating.py#L602 I was hoping that there might be some easy way to parse the...
Duplicate of #227
Should be fixed with PR #235, but I don't have a test binary for it yet.
Any `struct.error` raised from macholib should be handled by PR #242
The `lib_exts` parameter isn't even used by the caller. This could be replaced with a more reliable filter than the file suffix.
When I check to see what the main analysis function uses, `_is_macho_file` shows up again. Could probably use that here.
Testing shows `_is_macho_file` having false negatives with some test files (`liba.dylib`). I have PR #236 which seems to work but might need review.