python-hpOneView icon indicating copy to clipboard operation
python-hpOneView copied to clipboard

Add appliance network information

Open chrisarnott86 opened this issue 6 years ago • 6 comments

Description

This is my first ever contribution to a project on Github so please tread lightly...

A new module is added which enables collection of Appliance Network Interfaces information (api call GET https://{appl}/rest/appliance/network-interfaces)

Testing has been done via my own script, I haven't been able to get tox to complete, I don't think the errors I'm getting are related to the changes I've made, something to do with the general setup. Any advice on using tox is appreciated. (it's failing with an invocation error on flake8 after output shows examples/scmb/scmb.py:51:17: W504 line break after binary operator)

Check List

  • [x] New functionality includes testing.
    • [x] All tests pass for Python 2.7+ & 3.4+($ tox).
  • [ ] New functionality has been documented in the README if applicable.
    • [x] New functionality has been thoroughly documented in the examples (please include helpful comments).
    • [x] New endpoints supported are updated in the endpoints-support.md file.
  • [ ] Changes are documented in the CHANGELOG.

chrisarnott86 avatar Nov 05 '18 15:11 chrisarnott86

I have been able to get tox to complete successfully by adding a couple of ignores to tox.ini. The warnings I added were for files I hadn't touched. I found that checking out the master branch on python-hpOneView also gave the same errors so it's definitely not anything I've introduced.

Most of the warnings were W504 (line break after binary operator) and one was an invalid escape sequence (W605)

chrisarnott86 avatar Nov 06 '18 09:11 chrisarnott86

I have been able to get tox to complete successfully by adding a couple of ignores to tox.ini. The warnings I added were for files I hadn't touched. I found that checking out the master branch on python-hpOneView also gave the same errors so it's definitely not anything I've introduced.

Most of the warnings were W504 (line break after binary operator) and one was an invalid escape sequence (W605)

@chrisarnott86 - Thanks for your contributions. I have re-triggered the travis build and it's able to succeed now. May be there was some issue with the travis CI tool. Can you revert back your changes for tox.ini and check now.

soodpr avatar Dec 11 '18 17:12 soodpr

I've reverted tox.ini back to the original in my local copy, and I'm getting failed checks again. Here's the output:

examples/interconnects.py:127:7: W504 line break after binary operator
examples/scmb/ov_to_sm.py:152:17: W504 line break after binary operator
examples/scmb/ov_to_sm.py:153:17: W504 line break after binary operator
examples/scmb/ov_to_sm.py:186:21: W504 line break after binary operator
examples/scmb/ov_to_sm.py:187:21: W504 line break after binary operator
examples/scmb/ov_to_sm.py:188:21: W504 line break after binary operator
examples/scmb/ov_to_sm.py:189:21: W504 line break after binary operator
examples/scmb/scmb.py:50:17: W504 line break after binary operator
examples/scmb/scmb.py:51:17: W504 line break after binary operator
ERROR: InvocationError for command './one_view_dev/one_view_ca/.tox/py27-flake8/bin/flake8 hpOneView/ tests/ examples/' (exited with code 1)

Presumably the travis buld is currently only working because of my changed tox.ini?

chrisarnott86 avatar Dec 12 '18 08:12 chrisarnott86

@chrisarnott86 - ok. May be I was wrong in understanding how Travis builds the code. I thought it takes that point of committed code. You ca ignore my comment.

soodpr avatar Dec 14 '18 14:12 soodpr

Given that the travis checks are failing in relation to files unrelated to my pull request, it shouldn't hinder checking of my commits. Does anyone else find that the tox checks fail on a fresh checkout of master?

chrisarnott86 avatar Dec 17 '18 11:12 chrisarnott86

Any updates here?

sijeesh avatar Mar 25 '19 12:03 sijeesh