python-hpOneView icon indicating copy to clipboard operation
python-hpOneView copied to clipboard

Add functionality to enclosures.py

Open elliottkat opened this issue 7 years ago • 5 comments

Hi all,

I have an existing repository that is useful for adding multiple enclosures, creating SPTs, and then using these SPTs to create SPs. The process, for the most part, is automated from end-to-end.

I would, however, like to see about being incorporated in the python-hpOneView SDK. I have modified enclosures.py to also allow the addition of multiple enclosures and would like to include it.

Is this something that would be of interest to you?

Katherine

elliottkat avatar May 30 '17 17:05 elliottkat

Yes. Please submit a PR with the changes and we'll review.

bsoutham avatar May 30 '17 17:05 bsoutham

Can someone tell me the process for creating a PR? I cloned the repository and created a new branch but when I try a push, I'm prompted for my GitHub credentials. I have SSH keys on GitHub for the Canareez project, but it is not in the HewlettPackard organization. Does someone need to give me additional privileges for the HewlettPackard organization?

elliottkat avatar Jun 01 '17 12:06 elliottkat

Hi @elliottkat

To submit PRs you need to fork this repo, clone the fork on your machine, push the changes, and then open a PR here.

This way you won't need any additional prvileges to do so.

I hope it helps! :smile:

tmiotto avatar Jun 01 '17 14:06 tmiotto

Thanks, Thiago, I'll give that a try.

elliottkat avatar Jun 01 '17 14:06 elliottkat

Hi @elliottkat - any update on it?

soodpr avatar Mar 13 '18 06:03 soodpr