Quinton Miller

Results 253 comments of Quinton Miller

@potomak are you interested in turning those checks into syntax warnings similar to #12427?

A different use of ordered mode is to explicitly turn option flags into regular positional arguments. This is useful for `crystal eval`. Consider the following: ``` $ crystal eval puts...

I cannot reproduce the CI failure locally; the same `compiler_spec.exe` executable runs properly on my laptop when downloaded as an artifact. I will look into this later.

It seems Windows CI is [working again](https://github.com/crystal-lang/crystal/runs/6676707128?check_suite_focus=true), all that's left is fixing the WASI one.

After countless pushes I have identified that `std_spec` breaks only when `Thread::Mutex#finalize` is defined. It doesn't matter if the body really deletes the critical section object. Other than that I...

Yes, it probably will fail for strings containing characters outside the BMP. JavaScript's [`String.prototype.charCodeAt`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/charCodeAt) says: > If the Unicode code point cannot be represented in a single UTF-16 code unit...

Array-like and hash-like literals are also covered. Before: ```crystal __temp_1 = Set(T)(typeof(1, 2, begin __temp_2 = Deque(T)(typeof(1, 2)).new __temp_2

A more realistic example, this nested container in the standard library specs: https://github.com/crystal-lang/crystal/blob/5de237e052004bca0e5a43e903139558f5368a2a/spec/std/crypto/subtle_spec.cr#L6-L11 Before ```crystal __temp_1 = ::Array(typeof(begin __temp_3 = ::Hash(typeof("a", "b", "result"), typeof(Slice.new(1, 17), Slice.new(1, 17), true)).new __temp_3["a"] =...

Some expansions are actually _longer_ when they don't involve `typeof` expressions, i.e. when the container literals use `of` and the container-like literals don't use uninstantiated generics. Take this example from...

I think the issue is currently all top-level funs are implicitly exported, so if we simply adjust wasm's linker command it too will export everything, including e.g. our own re-implementations...